Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bottlerocket-update-operator): Add an option to specify topologySpreadConstraints for the apiserver deployment resource. #672

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

AviorSchreiber
Copy link
Contributor

Description of changes:
Add an option to specify topologySpreadConstraints for the apiserver deployment resource.

Testing done:
I manually tested this by running the helm template with the default values to ensure the default behavior is retained. Then, I added the following values to verify that the new topologySpreadConstraints was applied to the deployment resource.

placement:
  apiserver: 
    topologySpreadConstraints:
    - maxSkew: 1
      topologyKey: kubernetes.io/hostname
      whenUnsatisfiable: DoNotSchedule
      labelSelector:
        matchLabels:
          brupop.bottlerocket.aws/component: agent
    - maxSkew: 1
      topologyKey: topology.kubernetes.io/zone
      whenUnsatisfiable: ScheduleAnyway
      labelSelector:
        matchLabels:
          brupop.bottlerocket.aws/component: agent

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

…SpreadConstraints for the apiserver deployment resource.
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your contribution!

@yeazelm yeazelm merged commit 2f6bfcf into bottlerocket-os:develop Aug 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants