-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Smallish cleanups to docs & unit tests; improve a few tests #3219
Comments
Comment by njx Open for committers to review. |
Comment by TomMalbran I just reviewed this request, so I guess I assigned it to myself. It all looks great, just some minor comments. |
Comment by peterflynn
Not important for the current sprint though, so later this week is fine either way. |
Comment by TomMalbran
The new changes seem good, but instead of re-indenting, what about creating a new variable instead of replacing the old ones? With a new var statement, the strings can be aligned, and in some cases it makes it easier to read the tested code text. |
Comment by peterflynn
|
Comment by TomMalbran
|
Comment by peterflynn
|
Comment by TomMalbran
|
Comment by peterflynn
|
Comment by TomMalbran Thanks for the cleanups. Merging now. |
Issue by peterflynn
Friday Apr 12, 2013 at 21:40 GMT
Originally opened as adobe/brackets#3429
docs for new fileNames option, etc.)
peterflynn included the following code: https://github.com/adobe/brackets/pull/3429/commits
The text was updated successfully, but these errors were encountered: