This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Smallish cleanups to docs & unit tests; improve a few tests #3429
Merged
Commits on Apr 12, 2013
-
Cleanups, mainly to unit tests:
- Improve docs in SpecRunnerUtils - Add assertion in SRU in case a mock Document is created without an Editor but then used in a way that would auto-create an Editor (which won't get cleaned up) - Add assertion in _destroyEditorIfUnneeded() since its name makes it easy to call with the wrong type (including via SRU.destroyMockEditor()) - Rename HTML code hints suite & remove unused var - Minor docs cleanups in LanguageManager (incorrect usage of "i.e.", missing docs for new fileNames option, etc.) - Add unit tests for install dialog cases where installer comes back with a result after clicking Cancel but before Cancel times out, or comes back vary late after timeout once user has opted to close the dialog - Remove a duplicated LanguageManager test (due to f67cfcd) - Add a few more StringMatch tests to ensure tricky cases don't break in the opposite direction as before
Configuration menu - View commit details
-
Copy full SHA for 5dc6489 - Browse repository at this point
Copy the full SHA 5dc6489View commit details -
* DocumentManager: use CollectionUtils.forEach() in notifyPathNameChanged() (removing early-exit optimization that's probably unneeded; can reintroduce when CollectionUtils.some() lands) * Move filename->language mapping tests from Editor-test to LanguageManager-test * Add another #330 testcase as suggested by Glenn in #3064 * Add StringMatch testcases as suggested by Kevin in #3417 * SpecRunnerUtils: use waitsForDone() more * CSSUtils-test: remove unused vars * Dialogs: tiny docs improvement
Configuration menu - View commit details
-
Copy full SHA for 045fae6 - Browse repository at this point
Copy the full SHA 045fae6View commit details
Commits on Jul 23, 2013
-
Merge remote-tracking branch 'origin/master' into pflynn/unit-test-cl…
…eanups * origin/master: (1140 commits) Documentation nits from code review Updated by ALF automation. Updated by ALF automation. Unit test for Save As bug related to untitled documents (see note at #4468 (comment)). Fixed as a side effect of PR #4514. - Add unit test that @bchintx wrote to cover #4484. - Remove redundant timeout args in unit tests (same val as default) - Fix JSLint whitespace errors I noticed in ProjectManager Using "workingSetSort" instead of "workingSetAdd" in certain cases of addToWorkingSet() was problematic, since FileViewController attaches specific meaning only to the latter. Cosmetic tweaks to modal header background color, tables, and typography. Attempt a cleaner fix for bug #4484 (Working set broken after Save As / save untitled outside project): * addToWorkingSet() ensures item is moved to requested index, even if it was already in the working set at some other index * Add a force flag, so we can guarantee a redraw after suppressing it during removal earlier * Call handleFileAddToWorkingSet() directly from _doSaveAs() to simplify plumbing (no advantage to going through FileViewController in this case) code review comments add registry URLs add unit tests for update button and registryUpdate event fix async close of dialog in afterEach update extension manager spinner and registry UI unit tests. update sanity check string. when prompting to save-as an untitled document, activate that document in the editor Updated by ALF automation. Disabling failing unit tests code review comments part 2 change layout for extension manager messages Updated by ALF automation. oops, of course can't use CollectionUtils... ... Conflicts: src/language/LanguageManager.js src/widgets/Dialogs.js test/spec/Editor-test.js test/spec/FileIndexManager-test.js test/spec/InstallExtensionDialog-test.js test/spec/SpecRunnerUtils.js
Configuration menu - View commit details
-
Copy full SHA for f59be5a - Browse repository at this point
Copy the full SHA f59be5aView commit details -
Fix JSLint/JSHint errors (some of which were on master).
Small docs & formatting tweaks. Fix merge cruft in Editor-test & CSSUtils-test.
Configuration menu - View commit details
-
Copy full SHA for 7250b96 - Browse repository at this point
Copy the full SHA 7250b96View commit details
Commits on Jul 30, 2013
-
Merge remote-tracking branch 'origin/master' into pflynn/unit-test-cl…
…eanups * origin/master: (30 commits) turn off optimization in acorn (but not acorn_loose right now) cleanup unit test prefs temporarily switch to my tern Revert "Revert "Workaround for the Tern crash."" Update README.md Work around #4554 (Extension Manager font is hard to read on Windows), which is a Chromium bug, by avoiding the lightest font-weight on Win. Lighten the text slightly so it's still a little muted, like the design looks on Mac and with older CEFs on Win. Revert "Workaround for the Tern crash." Updated by ALF automation. Re-add toolbar hover. Fix some button appearance issues. Updated by ALF automation. * Fix bug #4548 - remove Save As from folder tree context menu * Fix exception thrown when File > Save As invoked with nothing open * Update docs for working set events to reflect PR #4450 integration tests for registerInlineEditProvider Fixes after review JSDoc fixes. Fix for extensions compare show error message and add safety check For #4535, show error message but not 'remove' link for bad extension in dev folder Refactor provider callback for export Generalize registerInlineEditProvider and registerInlineDocProvider to take an optional priority parameter change upper limit to 16000 ...
Configuration menu - View commit details
-
Copy full SHA for 8d94d0d - Browse repository at this point
Copy the full SHA 8d94d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98f23f2 - Browse repository at this point
Copy the full SHA 98f23f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9df7830 - Browse repository at this point
Copy the full SHA 9df7830View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.