This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix exception when _noMatchCache contains the 'hasOwnProperty' property #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
This should use CollectionUtils.hasProperty() like the code just below here. Good catch though! Can't believe we missed that in the last round of fixes for this (#3004). |
|
I was going to make the same suggestion. I also added this test in the process: it("should not have problem with a cache entry called hasOwnProperty", function () {
var matcher = new StringMatch.StringMatcher();
matcher._noMatchCache.hasOwnProperty = true;
matcher.match("foo", "bar");
// no exception
}); |
|
Looks good, thanks for the fast turnaround! @dangoor I'm putting together a little unit-test cleanup pull request that adds a few small testcases... I can tack on your unit test suggestion there so it gets in soon. |
peterflynn
added a commit
that referenced
this pull request
Apr 12, 2013
Fix exception when _noMatchCache contains the 'hasOwnProperty' property
|
thanks @peterflynn! |
peterflynn
added a commit
that referenced
this pull request
Apr 12, 2013
* DocumentManager: use CollectionUtils.forEach() in notifyPathNameChanged() (removing early-exit optimization that's probably unneeded; can reintroduce when CollectionUtils.some() lands) * Move filename->language mapping tests from Editor-test to LanguageManager-test * Add another #330 testcase as suggested by Glenn in #3064 * Add StringMatch testcases as suggested by Kevin in #3417 * SpecRunnerUtils: use waitsForDone() more * CSSUtils-test: remove unused vars * Dialogs: tiny docs improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When _noMatchCache sets "hasOwnProperty" as a property it overwrites the "hasOwnProperty" function. An exception will be thrown on the next call to _noMatchCache.hasOwnProperty().