This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix bug #330 (Calling FileIndexManager.getFileInfoList() fails if another such call in progress) #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r such call is already in progress fails) - keep track of existing index-sync promise so we can just wait on it instead of failing.
|
What happens if you have a pending request that is different than the new request? For example: |
|
I'll answer my own question - it works :-) |
|
Thanks for fixing this! I ran into this problem again the other day and was going to fix it, but you beat me to it. Merging. |
gruehle
added a commit
that referenced
this pull request
Mar 7, 2013
Fix bug #330 (Calling FileIndexManager.getFileInfoList() fails if another such call in progress)
peterflynn
added a commit
that referenced
this pull request
Apr 12, 2013
* DocumentManager: use CollectionUtils.forEach() in notifyPathNameChanged() (removing early-exit optimization that's probably unneeded; can reintroduce when CollectionUtils.some() lands) * Move filename->language mapping tests from Editor-test to LanguageManager-test * Add another #330 testcase as suggested by Glenn in #3064 * Add StringMatch testcases as suggested by Kevin in #3417 * SpecRunnerUtils: use waitsForDone() more * CSSUtils-test: remove unused vars * Dialogs: tiny docs improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug #330 (Calling FileIndexManager.getFileInfoList() fails if another such call is in progress):
Keep track of existing index-sync promise so we can just wait on it instead of failing. Includes unit test.