Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] More CSS parsing unit tests (and beef up EditorManager docs) #356

Open
core-ai-bot opened this issue Aug 29, 2021 · 4 comments
Open

Comments

@core-ai-bot
Copy link
Member

Issue by peterflynn
Thursday Mar 01, 2012 at 19:06 GMT
Originally opened as adobe/brackets#358



peterflynn included the following code: https://github.com/adobe/brackets/pull/358/commits

@core-ai-bot
Copy link
Member Author

Comment by chrisbank
Thursday Mar 01, 2012 at 19:22 GMT


reviewing

@core-ai-bot
Copy link
Member Author

Comment by chrisbank
Thursday Mar 01, 2012 at 19:43 GMT


@peterflynn looks good. Just fix the lint errors on that line.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Mar 01, 2012 at 20:02 GMT


I fixed the JSLint errors and added more !/? to that comment.
I also realized the docs for expectParseError()'s 2nd arg were totally wrong (doh!), so I fixed that.
Finally, I added a few more cases to cover additional parsing errors Randy mentioned in issue #343.

@core-ai-bot
Copy link
Member Author

Comment by chrisbank
Thursday Mar 01, 2012 at 22:10 GMT


looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant