This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
More CSS parsing unit tests (and beef up EditorManager docs) #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/master: Update CodeMirror SHA Update CodeMirror SHA For issue 344, make sure we don't show horizontal scrollbars within an inline editor
* origin/master: Fix issue #341 Don't adjust endLine on inline editors.
|
reviewing |
| manager._loadString(cssCode); | ||
|
|
||
| // shouldn't get here since _loadString() is expected to throw | ||
| this.fail("Expected parse error: "+cssCode); |
There was a problem hiding this comment.
This line is showing 3 JS Lint errors
- Further improve EditorManager.createInlineEditorFromText() docs
|
@peterflynn looks good. Just fix the lint errors on that line. |
…rror() - Add more expected failures for the additional cases Randy found in issue #343
|
I fixed the JSLint errors and added more !/? to that comment. |
|
looks good |
chrisbank
added a commit
that referenced
this pull request
Mar 1, 2012
More CSS parsing unit tests (and beef up EditorManager docs)
gideonthomas
pushed a commit
to gideonthomas/brackets
that referenced
this pull request
Jul 6, 2015
Don't double-fire bramble:loaded, and Bramble ready event
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EditorManager.createInlineEditorFromText()better; in particular, the semantics ofrange