[CLOSED] Remove dialog close button #6279

[core-ai-bot]

Issue by WebsiteDeveloper
Friday Dec 27, 2013 at 21:39 GMT
Originally opened as adobe/brackets#6329

---

Remove dialog close button #6279

---

WebsiteDeveloper included the following code: https://github.com/adobe/brackets/pull/6329/commits

[core-ai-bot]

Comment by TomMalbran
Saturday Dec 28, 2013 at 02:06 GMT

---

You missed the ones in the debug extension, on both modal dialog templates.

[core-ai-bot]

Comment by WebsiteDeveloper
Saturday Dec 28, 2013 at 14:08 GMT

---

@TomMalbran thanks

[core-ai-bot]

Comment by TomMalbran
Sunday Dec 29, 2013 at 19:18 GMT

---

No problem. Notice that on the perf dialog you will need to add a close button, since without the x you can only close it using esc.

[core-ai-bot]

Comment by kkarlesk
Thursday Jan 02, 2014 at 18:19 GMT

---

@TomMalbran Would you please review?

[core-ai-bot]

Comment by TomMalbran
Monday Jan 06, 2014 at 17:44 GMT

---

@kkarlesk Will do.

@WebsiteDeveloper I think you removed all the "x" buttons, but there is still the issue with the perf window not having a close button.

[core-ai-bot]

Comment by redmunds
Monday Jan 06, 2014 at 17:48 GMT

---

It looks like the perf window has a hard-coded "x" button, so just verify that it's still there after removing the global one.

[core-ai-bot]

Comment by TomMalbran
Monday Jan 06, 2014 at 18:00 GMT

---

Is not really hard coded since it uses a custom modal dialog template. Should we keep that "x" button or replace it with a "close" button on the dialog footer?

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Jan 06, 2014 at 18:10 GMT

---

i just re-added the close button because@larz0 recently opened an issue concerning the improvement of the performance dialog see #6347

[core-ai-bot]

Comment by WebsiteDeveloper
Monday Jan 06, 2014 at 19:22 GMT

---

@TomMalbran

[core-ai-bot]

Comment by TomMalbran
Tuesday Jan 07, 2014 at 00:17 GMT

---

Ok. I guess we can let larz decides if he wants the "x" icon or a close button in the future when he changes that window. Is also just a debug window is is not important.

We could merge it now