Remove dialog close button #6279

[WebsiteDeveloper]

Remove dialog close button #6279

[TomMalbran]

You missed the ones in the debug extension, on both modal dialog templates.

[WebsiteDeveloper]

@TomMalbran thanks

[TomMalbran]

No problem. Notice that on the perf dialog you will need to add a close button, since without the x you can only close it using esc.

[kkarlesk]

@TomMalbran Would you please review?

[TomMalbran]

@kkarlesk Will do.

@WebsiteDeveloper I think you removed all the "x" buttons, but there is still the issue with the perf window not having a close button.

[redmunds]

It looks like the perf window has a hard-coded "x" button, so just verify that it's still there after removing the global one.

[TomMalbran]

Is not really hard coded since it uses a custom modal dialog template. Should we keep that "x" button or replace it with a "close" button on the dialog footer?

[WebsiteDeveloper]

i just re-added the close button because @larz0 recently opened an issue concerning the improvement of the performance dialog see #6347

[WebsiteDeveloper]

@TomMalbran

[TomMalbran]

Ok. I guess we can let larz decides if he wants the "x" icon or a close button in the future when he changes that window. Is also just a debug window is is not important.

We could merge it now