Consider removing "x" buttons from dialogs

[njx]

We currently have "x" buttons in the upper right-hand corner of most (though not all) dialogs. These seem superfluous since we always have cancel buttons in the button bar at the bottom, and add yet another thing we have to handle specially in dialogs. It seems like we should be consistent one way or another (always have them or never have them), and I'd vote for just removing them entirely.

[njx]

To @larz0 for consideration. I feel like we talked about this at some point before.

[thany]

To be brutally honest, I clicked around and couldn't find any dialogs that have the close button at the top-right (on windows, presumably). Only the open/save dialogs, but those are default windows things and are the same for every application.

I'm actually for keeping the X button, because it's just a cancel action in the end. Some folks are used to clicking that instead of cancel, and I see no reason to force those folks into getting used to something else, especially since the X button is in noone's way.

But as said, it seems there aren't any X buttons to be found, other than in default windows dialogs. That, or I haven't found all of them yet.

[larz0]

We can give it a try by hiding it and if people don't notice it then we can remove it completely.

I've worked on projects where users prefer the top close buttons but not sure if they're the majority.

[njx]

One example is in the "save changes" dialog - make a change in a file and then try to close it. Another is in the dialog you get that prompts you to quit Brackets after removing or updating an extension.

I mostly care about the inconsistency - I'm fine either keeping them or getting rid of them, but we should be consistent. (I'd forgotten that on Windows it's standard to have the close box in dialogs.)

[razster]

My company designs enrollment and demographic software, we have long since removed the default windows 'x' buttons and offer the cancel button or the 'do not save & exit'.

I personally would not notice it missing.

I would suggest looking at other applications and seeing if they use the windows/mac 'x' button or not, always a good source.

[larz0]

It makes sense for certain OS dialogs to have them because it's possible for the bottom of the dialog to go beyond the screen.

[njx]

Low pri to @larz0 to make a final call.

[thany]

Also good to keep in mind keyboard navigation. If the X button is removed (I sure hope not, but okay) then the Esc key should still dismiss that dialog with a "negative" action (if any), so to speak.

[njx]

Yup, all dialogs should already be handling Esc properly by default.

[larz0]

@njx let's remove it 👍

[larz0]

@njx @ WebsiteDeveloper FYI Randy pointed out that "Performance Data" Dialog doesn't have a close button at the bottom. (It needs some love anyway. I already submitted an issue.)

[TomMalbran]

FBNC. Back to @njx.

[njx]

Looks good. Thanks @WebsiteDeveloper and @TomMalbran! Closing.