[CLOSED] Issue #6587 - Added language self names to strings-app.js

[core-ai-bot]

Issue by ghost
Friday Jan 31, 2014 at 21:59 GMT
Originally opened as adobe/brackets#6725

---

#6587. Added language self names in strings-app.js that will be used in favor of localized version for switch language menu. If it doesn't have a self name it will revert back to the current language translation and if that doesn't exist it will default to the English name.

The ones that didn't have a translation in their specific locale files are: Italian, Norwegian, Polish, and Russian. I didn't want to use use Google Translate or some other method for finding out the self names. I'm hoping that we can get people who are more familiar with the language to fill in these gaps.

---

ghost included the following code: https://github.com/adobe/brackets/pull/6725/commits

[core-ai-bot]

Comment by MarcelGerber
Saturday Feb 01, 2014 at 00:31 GMT

---

Couldn't we remove these strings from the normal translation files afterwards?

[core-ai-bot]

Comment by ghost
Saturday Feb 01, 2014 at 00:47 GMT

---

We could get rid of a lot of them right now since most of the language self name list is complete. However, once we get a complete list of language self names I don't see a reason to keep any of the normal translation strings around.

[core-ai-bot]

Comment by MarcelGerber
Saturday Feb 01, 2014 at 11:31 GMT

---

I think it'd be good enough to take the self translations from the Google language dialog or something similar.
But needn't we some changes in the Dialog itself, too?

[core-ai-bot]

Comment by ghost
Monday Feb 03, 2014 at 19:54 GMT

---

Thanks for the link to the Google Language settings page, I was able to pull the remaining self names from that list. I've also gone through and removed the rest of the LOCALE_** from the original string.js file per language too.

What were you thinking about changes to the Dialog itself?

[core-ai-bot]

Comment by MarcelGerber
Tuesday Feb 04, 2014 at 14:40 GMT

---

No, I thought the wrong thing, everything is alright (have tested it, looks good).

[core-ai-bot]

Comment by RaymondLim
Wednesday Feb 12, 2014 at 01:37 GMT

---

@mjherna1 I tested and It looks good and works great. Before I can merge, can you sync to master again and resolve the conflicts in all strings files?

[core-ai-bot]

Comment by MarcelGerber
Saturday Feb 15, 2014 at 15:11 GMT

---

There's a malicious CodeMirror submodule commit. Could you do git submodule update after syncing to master?

[core-ai-bot]

Comment by RaymondLim
Thursday Feb 20, 2014 at 05:25 GMT

---

@mjherna1 You have an old SHA for CodeMirror module in your merge to master. Could you please correct it so that I can land this in master?

[core-ai-bot]

Comment by ghost
Monday Feb 24, 2014 at 08:49 GMT

---

@RaymondLim Sorry about that. The CodeMirror module should now be up-to-date and I've re-updated to Master as of 2/23/14. Let me know if you need anything else.

[core-ai-bot]

Comment by TomMalbran
Monday Feb 24, 2014 at 20:18 GMT

---

@mjherna1 You still need to sign the Brackets contributor license agreement.

[core-ai-bot]

Comment by RaymondLim
Monday Feb 24, 2014 at 20:31 GMT

---

@TomMalbran He is one supposed to be in our whitelist. I'll be taking care of it soon.

[core-ai-bot]

Comment by TomMalbran
Monday Feb 24, 2014 at 20:33 GMT

---

Oh, sorry about that then.

[core-ai-bot]

Comment by MarcelGerber
Tuesday Feb 25, 2014 at 19:53 GMT

---

Nice, but we should edit https://github.com/adobe/brackets/blob/master/src/nls/README.md point 3.

[core-ai-bot]

Comment by ghost
Wednesday Feb 26, 2014 at 01:41 GMT

---

I've sent in a new pull request (since this one is now closed) with the README.md updated to indicate the new location.