Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Issue #6587 - Added language self names to strings-app.js #6725

Merged
merged 2 commits into from Feb 24, 2014
Merged

Issue #6587 - Added language self names to strings-app.js #6725

merged 2 commits into from Feb 24, 2014

Conversation

ghost
Copy link

@ghost ghost commented Jan 31, 2014

#6587. Added language self names in strings-app.js that will be used in favor of localized version for switch language menu. If it doesn't have a self name it will revert back to the current language translation and if that doesn't exist it will default to the English name.

The ones that didn't have a translation in their specific locale files are: Italian, Norwegian, Polish, and Russian. I didn't want to use use Google Translate or some other method for finding out the self names. I'm hoping that we can get people who are more familiar with the language to fill in these gaps.

@marcelgerber
Copy link
Contributor

Couldn't we remove these strings from the normal translation files afterwards?

@ghost
Copy link
Author

ghost commented Feb 1, 2014

We could get rid of a lot of them right now since most of the language self name list is complete. However, once we get a complete list of language self names I don't see a reason to keep any of the normal translation strings around.

@marcelgerber
Copy link
Contributor

I think it'd be good enough to take the self translations from the Google language dialog or something similar.
But needn't we some changes in the Dialog itself, too?

@ghost
Copy link
Author

ghost commented Feb 3, 2014

Thanks for the link to the Google Language settings page, I was able to pull the remaining self names from that list. I've also gone through and removed the rest of the LOCALE_** from the original string.js file per language too.

What were you thinking about changes to the Dialog itself?

…r of localized version for switch language menu
@marcelgerber
Copy link
Contributor

No, I thought the wrong thing, everything is alright (have tested it, looks good).

@RaymondLim
Copy link
Contributor

@mjherna1 I tested and It looks good and works great. Before I can merge, can you sync to master again and resolve the conflicts in all strings files?

@marcelgerber
Copy link
Contributor

There's a malicious CodeMirror submodule commit. Could you do git submodule update after syncing to master?

@RaymondLim
Copy link
Contributor

@mjherna1 You have an old SHA for CodeMirror module in your merge to master. Could you please correct it so that I can land this in master?

@ghost
Copy link
Author

ghost commented Feb 24, 2014

@RaymondLim Sorry about that. The CodeMirror module should now be up-to-date and I've re-updated to Master as of 2/23/14. Let me know if you need anything else.

@TomMalbran
Copy link
Contributor

@mjherna1 You still need to sign the Brackets contributor license agreement.

@RaymondLim
Copy link
Contributor

@TomMalbran He is one supposed to be in our whitelist. I'll be taking care of it soon.

@TomMalbran
Copy link
Contributor

Oh, sorry about that then.

RaymondLim added a commit that referenced this pull request Feb 24, 2014
…-name

Issue #6587 - Added language self names to strings-app.js
@RaymondLim RaymondLim merged commit 3ed999a into adobe:master Feb 24, 2014
@marcelgerber
Copy link
Contributor

Nice, but we should edit https://github.com/adobe/brackets/blob/master/src/nls/README.md point 3.

@ghost
Copy link
Author

ghost commented Feb 26, 2014

I've sent in a new pull request (since this one is now closed) with the README.md updated to indicate the new location.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants