-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Issue #6587 - Added language self names to strings-app.js #6725
Conversation
Couldn't we remove these strings from the normal translation files afterwards? |
We could get rid of a lot of them right now since most of the language self name list is complete. However, once we get a complete list of language self names I don't see a reason to keep any of the normal translation strings around. |
I think it'd be good enough to take the self translations from the Google language dialog or something similar. |
Thanks for the link to the Google Language settings page, I was able to pull the remaining self names from that list. I've also gone through and removed the rest of the LOCALE_** from the original string.js file per language too. What were you thinking about changes to the Dialog itself? |
…r of localized version for switch language menu
No, I thought the wrong thing, everything is alright (have tested it, looks good). |
@mjherna1 I tested and It looks good and works great. Before I can merge, can you sync to master again and resolve the conflicts in all strings files? |
There's a malicious CodeMirror submodule commit. Could you do |
@mjherna1 You have an old SHA for CodeMirror module in your merge to master. Could you please correct it so that I can land this in master? |
@RaymondLim Sorry about that. The CodeMirror module should now be up-to-date and I've re-updated to Master as of 2/23/14. Let me know if you need anything else. |
@mjherna1 You still need to sign the Brackets contributor license agreement. |
@TomMalbran He is one supposed to be in our whitelist. I'll be taking care of it soon. |
Oh, sorry about that then. |
…-name Issue #6587 - Added language self names to strings-app.js
Nice, but we should edit https://github.com/adobe/brackets/blob/master/src/nls/README.md point 3. |
I've sent in a new pull request (since this one is now closed) with the README.md updated to indicate the new location. |
#6587. Added language self names in strings-app.js that will be used in favor of localized version for switch language menu. If it doesn't have a self name it will revert back to the current language translation and if that doesn't exist it will default to the English name.
The ones that didn't have a translation in their specific locale files are: Italian, Norwegian, Polish, and Russian. I didn't want to use use Google Translate or some other method for finding out the self names. I'm hoping that we can get people who are more familiar with the language to fill in these gaps.