Skip to content
This repository has been archived by the owner on Jan 19, 2019. It is now read-only.

[FEAT][BREAKING][2/2][member-delimiter-style] Separate single/multiline config #206

Merged
merged 9 commits into from
Dec 11, 2018

Conversation

bradzacher
Copy link
Owner

@bradzacher bradzacher commented Dec 5, 2018

PRing against #203's branch for now so it's easier to see the changes in this PR.

Breaking change:

Changed config to split single and multiline config into two separate objects for better customisability
Before:

type Delimiter = 'none' | 'semi' | 'comma';
interface BaseConfig {
    delimiter ?: Delimiter
    requireLast ?: boolean
    singleLine ?: Delimiter
}
type Config = BaseConfig & {
    overrides ?: {
        interface ?: BaseConfig
        typeLiteral ?: BaseConfig
    }
}

After:

type Delimiter = 'none' | 'semi' | 'comma';
interface BaseConfig {
    multiline ?: {
        delimiter ?: 'none' | 'semi' | 'comma'
        requireLast ?: boolean
    }
    singleline ?: {
        delimiter ?: 'semi' | 'comma'
        requireLast ?: boolean
    }
}
type Config = BaseConfig & {
    overrides ?: {
        interface ?: BaseConfig
        typeLiteral ?: BaseConfig
    }
}

@bradzacher bradzacher added the WIP PRs that are work in progress label Dec 5, 2018
@bradzacher bradzacher removed the WIP PRs that are work in progress label Dec 6, 2018
@bradzacher bradzacher changed the title [WIP][FEAT][BREAKING][2/2][member-delimiter-style] Separate single/multiline config [FEAT][BREAKING][2/2][member-delimiter-style] Separate single/multiline config Dec 6, 2018
@bradzacher bradzacher changed the base branch from 92-single-line-member-delimiter to master December 11, 2018 02:20
# Conflicts:
#	lib/rules/member-delimiter-style.js
#	tests/lib/rules/member-delimiter-style.js
@bradzacher bradzacher merged commit 1acefaa into master Dec 11, 2018
@bradzacher bradzacher deleted the member-delimiter-config branch December 11, 2018 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants