Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing question mark on one of the onboarding tour screens #13876

Closed
LaurenWags opened this issue Feb 1, 2021 · 2 comments · Fixed by brave/brave-core#8164
Closed

missing question mark on one of the onboarding tour screens #13876

LaurenWags opened this issue Feb 1, 2021 · 2 comments · Fixed by brave/brave-core#8164
Assignees
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

On the onboarding tour slide titled "When do you receive rewards", there should be a question mark at the end of this title per #13488 (comment). Note, this applies to both narrow (from panel) and wide (from brave://rewards) views as it is missing in both.

Per discussion with @codybanxs this question mark should be added.

Steps to Reproduce

  1. Open either narrow or wide onboarding tour
  2. Go to the third slide/screen

Actual result:

question mark at the end of the title is missing:
wide3

Expected result:

Should read "When do you receive rewards?" per #13488 (comment)

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.20.95 Chromium: 88.0.4324.96 (Official Build) beta (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 10.15.7 (Build 19H15)
Brave 1.21.36 Chromium: 88.0.4324.96 (Official Build) nightly (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a not available in 1.19.x
  • Can you reproduce this issue with the beta channel? yes 1.20.x
  • Can you reproduce this issue with the nightly channel? yes 1.21.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @codybanxs @brave/legacy_qa @rebron

@btlechowski
Copy link

Reproduced on

Brave 1.20.97 Chromium: 88.0.4324.96 (Official Build) dev (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

In Polish locale.

image

@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Feb 5, 2021
@stephendonner stephendonner added this to the 1.24.x - Nightly milestone Mar 19, 2021
@stephendonner stephendonner self-assigned this Mar 19, 2021
@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 5, 2021
@LaurenWags
Copy link
Member Author

Verified passed with

Brave | 1.24.46 Chromium: 90.0.4430.41 (Official Build) nightly (x86_64)
-- | --
Revision | e9c92b1eaca8487e212f3f6bc081fdb6d4863759-refs/branch-heads/4430@{#723}
OS | macOS Version 10.15.7 (Build 19H524)

Verified STR from description.

Narrow view Wide view
Screen Shot 2021-04-05 at 8 58 27 AM Screen Shot 2021-04-05 at 8 58 43 AM

@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants