Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add question mark to Rewards-tour slide; fixes issue #13876 #8164

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add question mark to Rewards-tour slide; fixes issue #13876 #8164

merged 1 commit into from
Mar 18, 2021

Conversation

stephendonner
Copy link
Contributor

@stephendonner stephendonner commented Mar 6, 2021

Resolves brave/brave-browser#13876

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used GitHub auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#13876 (comment)

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephendonner stephendonner merged commit d348be0 into brave:master Mar 18, 2021
@stephendonner stephendonner added this to the 1.24.x - Nightly milestone Mar 19, 2021
@stephendonner stephendonner deleted the fix-13876 branch March 19, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing question mark on one of the onboarding tour screens
2 participants