Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full url like in Chrome #2192

Closed
ghost opened this issue Nov 20, 2018 · 10 comments
Closed

Show full url like in Chrome #2192

ghost opened this issue Nov 20, 2018 · 10 comments

Comments

@ghost
Copy link

ghost commented Nov 20, 2018

Test plan

  1. Visit Show full url like in Chrome #2192
  2. The full URL (Show full url like in Chrome #2192) should show in the URL bar

Description

Everytime I click on the URL, I have to click another time so it shows the full URL with https://.
This is so annoying! Chrome removed it few months ago, and Brave should as well.

@srirambv srirambv added suggestion priority/P5 Not scheduled. Don't anticipate work on this any time soon. labels Nov 20, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Nov 20, 2018
@fmarier
Copy link
Member

fmarier commented Dec 12, 2018

This corresponds to the "Omnibox UI Hide Steady-State URL Scheme" feature flag in chrome://flags. Disabling it will always show the full URL.

@cndouglas
Copy link
Contributor

Thanks @fmarier! Disabling #omnibox-ui-hide-steady-state-url-scheme in brave://flags does show the https protocol part of the URL.

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@LlamaFarma
Copy link

Is it just me, but this doesn't work for me fully.

For instance, if I go to www.google.com, it shows in the address bar as https://google.com.
If I click twice in the address bar it changes to the 'real' URL and shows https://www.google.com.
When I click away, the www goes.

I find this really annoying - I want to know the exact URL I'm on. Is there any way to fix it?

@cndouglas
Copy link
Contributor

@LlamaFarma You also need to disable the setting #omnibox-ui-hide-steady-state-url-trivial-subdomains
Go to brave://flags#omnibox-ui-hide-steady-state-url-trivial-subdomains and change it to Disabled:

@LlamaFarma
Copy link

Thanks - that worked @liunkae .
So, to summarise - if you want it to work the same way as Chrome, you need to disable both these settings...
#omnibox-ui-hide-steady-state-url-scheme
#omnibox-ui-hide-steady-state-url-trivial-subdomains

@Madis0
Copy link

Madis0 commented Apr 20, 2019

Hiding the protocol is fine - the lock/warning icon displays the status more accurately anyway (mixed content and whatnot).

However, hiding the www. is what received the huge backlash for a good reason - it is simply inaccurate. See also: https://bugs.chromium.org/p/chromium/issues/detail?id=883038

@drauch
Copy link

drauch commented Jun 10, 2019

Yep, please set "#omnibox-ui-hide-steady-state-url-trivial-subdomains" to Disabled by default! 👍

@rebron
Copy link
Collaborator

rebron commented Jun 10, 2019

Looks like this was addressed with #4283
cc: @jumde

We're showing full url by default in nightly and we'd be reverting from what we're doing in current release build. cc: @TomL

@bsclifton
Copy link
Member

Thanks for confirming, @rebron - this is indeed closed. I'll move it to the 0.68.x milestone 😄

@btlechowski
Copy link

btlechowski commented Aug 7, 2019

Verification passed on

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Verified steps from the description

image

Verification passed on

Brave 0.68.129 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR mentioned in the description

Verified passed with

Brave 0.68.131 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Verified STR from description
    Screen Shot 2019-08-20 at 5 46 40 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests