sync does not put Android bookmarks into folders #2447

GeetaSarvadnya · 2018-12-11T11:40:49Z

Description

Empty folders are synced in win, no bookmarks inside the folders.

Devices

Device 1: Windows 10 (Sync chain creator) - 0.58.11
Device 2: Android ARM - Samsung Galaxy J3 - 1.0.71 (sync2)

Steps to Reproduce

Actual result:

All the Android BM's are imported outside the folders, folder A and folder B are empty, no BM's inside the folders - Waited for almost 15 mins

Console log error:

[2548:2356:1211/161535.544:ERROR:CONSOLE(0)] "Error in event handler: TypeError: Cannot read property 'url' of undefined
at Object.NodeState.editBookmark (chrome://bookmarks/crisper.js:36:3143)
at Object.NodeState.updateNodes (chrome://bookmarks/crisper.js:36:4691)
at Object.reduceAction (chrome://bookmarks/crisper.js:36:7120)
at Store.reduce_ (chrome://bookmarks/crisper.js:44:1112)
at chrome://bookmarks/crisper.js:44:960
at Store.dispatchInternal_ (chrome://bookmarks/crisper.js:44:1015)
at Store.dispatchAsync (chrome://bookmarks/crisper.js:44:869)
at Store.dispatch (chrome://bookmarks/crisper.js:44:927)
at dispatch (chrome://bookmarks/crisper.js:48:726)
at onBookmarkChanged (chrome://bookmarks/crisper.js:48:785)", source: chrome://bookmarks/?id=3 (0)
[2548:2356:1211/161535.544:ERROR:CONSOLE(0)] "Error in event handler: TypeError: Cannot read property 'url' of undefined
at Object.NodeState.editBookmark (chrome://bookmarks/crisper.js:36:3143)
at Object.NodeState.updateNodes (chrome://bookmarks/crisper.js:36:4691)
at Object.reduceAction (chrome://bookmarks/crisper.js:36:7120)
at Store.reduce_ (chrome://bookmarks/crisper.js:44:1112)
at chrome://bookmarks/crisper.js:44:960
at Store.dispatchInternal_ (chrome://bookmarks/crisper.js:44:1015)
at Store.dispatchAsync (chrome://bookmarks/crisper.js:44:869)
at Store.dispatch (chrome://bookmarks/crisper.js:44:927)
at dispatch (chrome://bookmarks/crisper.js:48:726)
at onBookmarkChanged (chrome://bookmarks/crisper.js:48:785)", source: chrome://bookmarks/?id=3 (0)

Expected result:

Folders should not be empty

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows

Reproducible on current release:

Does it reproduce on brave-browser dev/beta builds? NA

Website problems only:

Does the issue resolve itself when disabling Brave Shields? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional Information

The text was updated successfully, but these errors were encountered:

LaurenWags · 2018-12-12T16:22:18Z

Reproduced with Device 1 as macOS (using build below) and Device 2 is Android

Brave	0.58.11 Chromium: 71.0.3578.80 (Official Build) beta(64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

encountered while testing Folder created on Android shows up without name #2144
Device 1 (macOS):

Device 2 (Android):

bbondy · 2018-12-12T19:08:50Z

I think empty folders should be synced, closing. LMK if I'm wrong though.

LaurenWags · 2018-12-12T19:12:42Z

@bbondy I think we should change the issue title - what i'm seeing (and I think @GeetaSarvadnya is too based on what she wrote in Actual Result: All the Android BM's are imported outside the folders, folder A and folder B are empty, no BM's inside the folders - Waited for almost 15 mins) is that if you have a folder on android which contains bookmarks, when that folder is synced to my laptop the folder is empty. the bookmarks are not inside the folder. If you take a look at my screenshots in the comment above, hopefully you can see what i mean. On the laptop the folder and bookmarks are there, but the bookmarks are not in the folder.

LaurenWags · 2018-12-12T19:39:10Z

Additional Steps to Reproduce:

Clean install 0.58.11.
Import some bookmarks (I imported about 45 from an HTML file).
Create Sync chain.
Install 1.0.71 sync2 on Android device.
Join sync chain.
Add bookmarks (and put some of those bookmarks into folders) on Android device.
Wait for bookmarks to be synced to laptop.
When Sync occurs, the bookmarks are not in the folder(s) you created on Android. (screenshots in sync does not put Android bookmarks into folders #2447 (comment))

I'm unable to test this with adding bookmarks to Android device prior to joining sync chain (essentially reverse steps 5 and 6 above) due to a different issue: https://github.com/brave/browser-android-tabs/issues/924

LaurenWags · 2018-12-12T19:47:45Z

seems like maybe the bookmark(s) on Android are being synced before I get them into a folder on my device? Then they get to laptop (Device 1) that way - meaning, out of the folder. Then this incorrect placement gets synced back to the Android device (Device 2).

btlechowski · 2018-12-12T20:25:04Z

Reproduced on Windows 7 x64(0.58.11) and Samsungs s7 (1.0.71(sync2)) using #2447 (comment) Steps.

AlexeyBarabash · 2018-12-13T17:24:49Z

Just verified PR brave/brave-core#1079 fixed issue.

GeetaSarvadnya · 2018-12-13T17:28:05Z

Issue is still not fixed, all the bookmarks are synced outside the folders on Windows (device1). Folders A and B are still empty in device1. Also, there is no Mobile Bookmarks folder on windows, now the folder A and B are displayed under Bookmarks bar which is not correct.

Android (device 2):

Console log error:

darkdh · 2018-12-13T17:29:25Z

@GeetaSarvadnya , the fix hasn't released with official build. @AlexeyBarabash was using his own build to verify

AlexeyBarabash · 2018-12-13T17:31:35Z

@GeetaSarvadnya , sorry for confusing. I was using own build from the latest master with merged PR.

kjozwiak · 2018-12-13T23:15:41Z

@GeetaSarvadnya thanks for checking this again! There were a few issues fixed relating to sync that went into 0.58.12 so I thought this might have been fixed. Looks like brave/brave-core#1079 needs to land before we can re-check. We'll need to wait for new builds 👍 Hopefully we'll have a new build by tomorrow AM.

GeetaSarvadnya · 2018-12-14T05:52:37Z

Verification passed on.

Brave	0.59.8 Chromium: 71.0.3578.98 (Official Build) beta (64-bit)
Revision	15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS	Windows

Verified STR from description.
Verified STR from sync does not put Android bookmarks into folders #2447 (comment)

Verified passed with

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Mac OS X

Verified STR from description
Verified STR from sync does not put Android bookmarks into folders #2447 (comment)

Verification passed on

Brave	0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision	997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS	Linux

Verified STR from description
Verified STR from sync does not put Android bookmarks into folders #2447 (comment)

GeetaSarvadnya added bug feature/sync QA/Yes QA/Test-Plan-Specified labels Dec 11, 2018

GeetaSarvadnya modified the milestones: 1.x Backlog, 0.58.x - Beta Dec 11, 2018

GeetaSarvadnya mentioned this issue Dec 12, 2018

Folder created on Android shows up without name #2144

Closed

bbondy closed this as completed Dec 12, 2018

bbondy modified the milestones: 0.58.x - Release, Dupe / Invalid / Not actionable Dec 12, 2018

LaurenWags changed the title ~~Empty folders are synced in win, no bookmarks inside the folders.~~ sync does not put Android bookmarks into folders Dec 12, 2018

bbondy reopened this Dec 12, 2018

bbondy assigned AlexeyBarabash Dec 12, 2018

LaurenWags modified the milestones: Dupe / Invalid / Not actionable, 0.58.x - Release Dec 12, 2018

LaurenWags added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 12, 2018

darkdh mentioned this issue Dec 13, 2018

Remove GetAllSyncData workaround for local overridden issue brave/brave-core#1079

Merged

18 tasks

darkdh closed this as completed in brave/brave-core#1079 Dec 13, 2018

GeetaSarvadnya added the QA Pass-Win64 label Dec 14, 2018

kjozwiak added the release-notes/exclude label Dec 18, 2018

This was referenced Dec 19, 2018

Manual test run on OS X for 0.58.x - Release #2646

Closed

Manual test run on Linux for 0.58.x - Release #2648

Closed

This was referenced Dec 20, 2018

[QA] 0.58.x sync issues that still need to be verified (macOS only) #2671

Closed

[QA] 0.58.x sync issues that still need to be verified (Linux only) #2673

Closed

srirambv mentioned this issue Jan 3, 2019

Android bookmarks moved inside a folder doesn't sync well with desktop #2798

Closed

LaurenWags added the QA Pass-macOS label Jan 3, 2019

btlechowski added the QA Pass-Linux label Jan 4, 2019

kjozwiak mentioned this issue Jan 31, 2019

Enabling Sync by default #3180

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sync does not put Android bookmarks into folders #2447

sync does not put Android bookmarks into folders #2447

GeetaSarvadnya commented Dec 11, 2018 •

edited by LaurenWags

Loading

LaurenWags commented Dec 12, 2018 •

edited

Loading

bbondy commented Dec 12, 2018

LaurenWags commented Dec 12, 2018 •

edited

Loading

LaurenWags commented Dec 12, 2018

LaurenWags commented Dec 12, 2018

btlechowski commented Dec 12, 2018

AlexeyBarabash commented Dec 13, 2018

GeetaSarvadnya commented Dec 13, 2018 •

edited

Loading

darkdh commented Dec 13, 2018

AlexeyBarabash commented Dec 13, 2018

kjozwiak commented Dec 13, 2018

GeetaSarvadnya commented Dec 14, 2018 •

edited by btlechowski

Loading

sync does not put Android bookmarks into folders #2447

sync does not put Android bookmarks into folders #2447

Comments

GeetaSarvadnya commented Dec 11, 2018 • edited by LaurenWags Loading

Description

Devices

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

Website problems only:

Additional Information

LaurenWags commented Dec 12, 2018 • edited Loading

bbondy commented Dec 12, 2018

LaurenWags commented Dec 12, 2018 • edited Loading

LaurenWags commented Dec 12, 2018

LaurenWags commented Dec 12, 2018

btlechowski commented Dec 12, 2018

AlexeyBarabash commented Dec 13, 2018

GeetaSarvadnya commented Dec 13, 2018 • edited Loading

darkdh commented Dec 13, 2018

AlexeyBarabash commented Dec 13, 2018

kjozwiak commented Dec 13, 2018

GeetaSarvadnya commented Dec 14, 2018 • edited by btlechowski Loading

GeetaSarvadnya commented Dec 11, 2018 •

edited by LaurenWags

Loading

LaurenWags commented Dec 12, 2018 •

edited

Loading

LaurenWags commented Dec 12, 2018 •

edited

Loading

GeetaSarvadnya commented Dec 13, 2018 •

edited

Loading

GeetaSarvadnya commented Dec 14, 2018 •

edited by btlechowski

Loading