Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change position of path text to below the code word text area #2525

Closed
srirambv opened this issue Dec 13, 2018 · 3 comments
Closed

Change position of path text to below the code word text area #2525

srirambv opened this issue Dec 13, 2018 · 3 comments
Assignees
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Change position of path text to below the code word text area

Steps to Reproduce

  1. Install 0.58.12
  2. Create a sync chain
  3. Add a computer using code words window
  4. Path info text is right below the header which might confuse users to enter that instead of code words

Actual result:

image

Expected result:

Inside outer gradient box or below the text field

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    No V2 UI isn't on beta/dev

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    NO
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information

cc: @bradleyrichter @rossmoody

@srirambv srirambv added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P5 Not scheduled. Don't anticipate work on this any time soon. release/not-blocking about-pages/sync QA/Yes release-notes/exclude QA/Test-Plan-Specified labels Dec 13, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 13, 2018
@rebron rebron added polish Nice to have — usually related to front-end/visual tasks and removed polish Nice to have — usually related to front-end/visual tasks labels Dec 14, 2018
@rebron
Copy link
Collaborator

rebron commented Dec 14, 2018

over to @bradleyrichter to rethink text.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 20, 2018
@rossmoody
Copy link
Contributor

rossmoody commented Dec 20, 2018

The most up to date design spec for this screen which addresses the hierarchy and verbiage concerns can be found right here.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 21, 2019

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta (64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Windows 10

image

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

screen shot 2019-01-23 at 4 29 28 pm

Verification passed on

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release/not-blocking release-notes/exclude
Projects
None yet
Development

No branches or pull requests

8 participants