Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking ok on info modal navigates back to sync home page #2541

Closed
srirambv opened this issue Dec 13, 2018 · 2 comments · Fixed by brave/brave-core#1129
Closed

Clicking ok on info modal navigates back to sync home page #2541

srirambv opened this issue Dec 13, 2018 · 2 comments · Fixed by brave/brave-core#1129

Comments

@srirambv
Copy link
Contributor

Description

Clicking ok on info modal navigates back to sync home page

Steps to Reproduce

  1. Clean install 0.58.12
  2. Click Enter a sync chain code to join a sync chain
  3. Do not enter any code words and click on Confirm sync code
  4. Click Ok on the info modal, navigates back to home screen

Actual result:

https://drive.google.com/open?id=1npiWvwxabuI2IIQezU3axdXqwolwflxU

Expected result:

Should only dismiss the info modal and not navigate back to home screen

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @brave/legacy_qa

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 26, 2018

@cezaraugusto Issue is reproducible on 0.59.12. Is the issue merged after the build (0.59.12) deployment?
2541

@btlechowski
Copy link

btlechowski commented Jan 2, 2019

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

2541

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

ezgif com-video-to-gif

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment