Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync needs a 'waiter' message when reset/confirm/remove #2567

Closed
srirambv opened this issue Dec 14, 2018 · 4 comments · Fixed by brave/brave-core#1193
Closed

Sync needs a 'waiter' message when reset/confirm/remove #2567

srirambv opened this issue Dec 14, 2018 · 4 comments · Fixed by brave/brave-core#1193
Assignees
@cezaraugusto
Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Dec 14, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1193

Description

Sync needs a 'waiter' message when reset/confirm/remove

Steps to Reproduce

  1. Add a device to sync chain
  2. Try removing it by clicking on the X button in the devices list
  3. Click on Remove in the popup modal, there is no UI indication that a request is sent. This could lead to user clicking the button unnecessarily

Actual result:

https://youtu.be/itrU8cV_ce4

Expected result:

Should have a waiter message similar to the one implemented in rewards(#1099)

Reproduces how often:

Easy

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

May be duplicate of #2227 @AlexeyBarabash to confirm and close this if its a dupe
@srirambv srirambv added design A design change, especially one which needs input from the design team feature/sync design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude labels Dec 14, 2018
@srirambv srirambv added this to the 1.x Backlog milestone Dec 14, 2018
@rebron rebron mentioned this issue Dec 14, 2018
Closed
@cezaraugusto cezaraugusto mentioned this issue Dec 20, 2018
Closed
@rossmoody
Copy link
Contributor

The most up to date design spec for Sync can be found right here.

cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 1, 2019
@cezaraugusto
update spec of sync devices/qr code/words modals
7d8718e 
close brave/brave-browser#2724
close brave/brave-browser#2591
address brave/brave-browser#2567
@cezaraugusto cezaraugusto mentioned this issue Jan 1, 2019
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
refactor modals to use store instead of state in Sync
76c3292 
fix brave/brave-browser#2677
fix brave/brave-browser#2564
address brave/brave-browser#2567
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
add a loading state for removing and reseting sync
021ad13 
fix brave/brave-browser#2567
fix brave/brave-browser#2629
@cezaraugusto cezaraugusto removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. design A design change, especially one which needs input from the design team labels Jan 2, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
add a loading state for adding, removing and reseting sync
bd48127 
fix brave/brave-browser#2567
fix brave/brave-browser#2629
@LaurenWags
Copy link
Member

Reproduced on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@cezaraugusto
add a loading state for adding, removing and reseting sync
24867f7 
fix brave/brave-browser#2567
fix brave/brave-browser#2629
@btlechowski
Copy link

Reproduced on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
@srirambv
Copy link
Contributor Author

srirambv commented Jan 8, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

screenshot from 2019-01-08 12-55-41
screenshot from 2019-01-08 12-55-03
screenshot from 2019-01-08 12-54-15

Verification passed on

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 10

image

image

image

image

Verified passed with

Brave 0.59.20 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix multiple sync issues brave/brave-core
8 participants
@cezaraugusto @bsclifton @bradleyrichter @srirambv @LaurenWags @rossmoody @btlechowski @GeetaSarvadnya