Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync section is in the wrong place in settings #2594

Closed
btlechowski opened this issue Dec 17, 2018 · 4 comments · Fixed by brave/brave-core#1127
Closed

Sync section is in the wrong place in settings #2594

btlechowski opened this issue Dec 17, 2018 · 4 comments · Fixed by brave/brave-core#1127
Assignees
@cezaraugusto
Labels
feature/global-settings Settings at browser level independent of shields settings feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@btlechowski
Copy link

Follow up from #1183

Steps to Reproduce

  1. Go to brave://settings
  2. Scroll down to Brave Sync

Actual result:

The section is between Brave shields defaults and On startup

image

Expected result:

Per comment #1183 (comment) Create new Extensions section in Settings beneath Extensions and before Shield Settings section

Brave version (brave://version info)

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

@rebron @cezaraugusto @brave/legacy_qa
@btlechowski btlechowski added feature/global-settings Settings at browser level independent of shields settings feature/sync QA/Yes QA/Test-Plan-Specified labels Dec 17, 2018
@btlechowski btlechowski added this to the 1.x Backlog milestone Dec 17, 2018
@btlechowski btlechowski mentioned this issue Dec 17, 2018
Closed
@LaurenWags
Copy link
Member

Reproduces on macOS

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Mac OS X

@cezaraugusto cezaraugusto self-assigned this Dec 17, 2018
@cezaraugusto cezaraugusto mentioned this issue Dec 18, 2018
Merged
@btlechowski
Copy link
Author

Reproduces on Ubuntu 17.10

Brave 0.58.14 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Linux

cezaraugusto added a commit to brave/brave-core that referenced this issue Dec 19, 2018
@cezaraugusto
put sync on top of shields in the settings page
40df7d8 
fix brave/brave-browser#2594
@bbondy bbondy modified the milestones: 1.x Backlog, 0.60.x - Dev Dec 20, 2018
@darkdh darkdh modified the milestones: 0.60.x - Dev, 0.59.x - Beta Dec 20, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Jan 2, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows 7

Used test plan from brave/brave-core#1127

image

@srirambv
Copy link
Contributor

srirambv commented Jan 3, 2019

Verification passed on Linux however the name is still not changed to Sync. Reopened the issue(#2758) as its being reproduced on several machines and needs to be investigated

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

image

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/global-settings Settings at browser level independent of shields settings feature/sync QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

put sync on top of shields in the settings page brave/brave-core
6 participants
@bbondy @cezaraugusto @darkdh @srirambv @LaurenWags @btlechowski