Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "view sync code" to "view QR code and Code words" followup to #2549 #2595

Closed
srirambv opened this issue Dec 17, 2018 · 3 comments · Fixed by brave/brave-core#1113
Closed

Rename "view sync code" to "view QR code and Code words" followup to #2549 #2595

srirambv opened this issue Dec 17, 2018 · 3 comments · Fixed by brave/brave-core#1113
Assignees
@cezaraugusto
Labels
feature/sync polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

"view sync code" might not be descriptive enough and might confuse with "add device" functionality. Renaming it to "view QR code and Code words" should make it more easy to differentiate the functionalities of both buttons.

Actual result:

img
@srirambv srirambv added this to the 0.58.x - Release milestone Dec 17, 2018
@cezaraugusto
Copy link
Contributor

moving to 0.59 per last sync meeting

cezaraugusto added a commit to brave/brave-core that referenced this issue Dec 17, 2018
@cezaraugusto
sync: rename view sync code to view qr code and code words
dd3f557 
brave/brave-browser#2595
-
button is localed in the right-hand side of devices table
@cezaraugusto cezaraugusto mentioned this issue Dec 17, 2018
Merged
@GeetaSarvadnya
Copy link

@cezaraugusto Issue still persists on 0.59.12, Is this not yet merged in 0.59.12?

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 29, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows
  • Verified the description mentioned in the issue.

image

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

  • Verified the description mentioned in the issue.
    image

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Feb 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync polish Nice to have — usually related to front-end/visual tasks QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

sync: rename view sync code to view qr code and code words brave/brave-core
5 participants
@bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya