Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two Planet Mozilla sources discovered, one of which can't be followed #26306

Closed
stephendonner opened this issue Oct 26, 2022 · 3 comments · Fixed by brave/brave-core#15775
Closed

Comments

@stephendonner
Copy link

Description

Two Planet Mozilla sources, one of which can't be followed

Steps to Reproduce

  1. install 1.47.20
  2. launch Brave
  3. open brave://flags
  4. toggle brave://flags/#brave-news-v2 to Enabled
  5. click on Relaunch
  6. open a new-tab page
  7. click Customize
  8. click Turn on Brave News
  9. beneath Discover, enter https://planet.mozilla.org/atom.xml
  10. click on Get feeds from https://planet.mozilla.org/atom.xml
  11. confirm one Planet Mozilla results under Sources
  12. hover over and click on the Follow button within
  13. wait
  14. you're subscribed to Planet Mozilla, but with an additional non-followable source

Actual result:

click Follow result
Screen Shot 2022-10-26 at 3 42 06 PM Screen Shot 2022-10-26 at 3 43 07 PM

Expected result:

Should either be able to follow whatever the 2nd feed is, or it shouldn't be showing up, since we can't follow it.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.47.20 Chromium: 107.0.5304.68 (Official Build) nightly (x86_64)
Revision a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS macOS Version 11.7.1 (Build 20G918)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @fallaciousreasoning @petemill @mattmcalister

@fallaciousreasoning
Copy link

Ah, I think this is actually a UX bug. Second one is the direct feed we discovered, first one is the direct feed we subscribed to 🤦

We had this working at one point but I guess it regressed. I'll take a look.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2022

The above requires 1.46.102 or higher for 1.46.x verification 👍

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.46.102 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
-- | --
Revision | 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS | Windows 11 Version 21H2 (Build 22000.1219)

Verified using STR from brave/brave-core#15820 (comment)

Confirmed I was subscribed to the Planet Mozilla feed, without duplicate sources/cards, via direct-feed search.

example example example example example
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment