[Uplift] [Brave News] Fix direct feeds & scrolling bug #15820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
fallaciousreasoning
changed the title
fallaciousreasoning
changed the base branch from
1.46.x
to
1.46.x-bn-channels-carousels-styles
fallaciousreasoning
force-pushed
the
bn-uplifts
branch
from
4f17ea1
to
50c1300
Compare
|
A Storybook has been deployed to preview UI for the latest push |
Base automatically changed from
1.46.x-bn-channels-carousels-styles
to
1.46.x
November 8, 2022 06:02
fallaciousreasoning
force-pushed
the
bn-uplifts
branch
from
50c1300
to
71aacbe
Compare
|
A Storybook has been deployed to preview UI for the latest push |
Verification
|
| Brave | 1.47.56 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64) |
|---|---|
| Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
| OS | macOS Version 11.7.1 (Build 20G918) |
Issue 26271 - PASSED
- installed
1.47.56 - launched Brave
- opened a new-tab page
- set
brave://flags/#brave-news-v2toEnabled - clicked on
Relaunch - clicked on
Customize - clicked on Turn on Brave News
- via
Follow, added a bunch of sources and/or channels (so there's a need to scroll the list in theFollowingpane) - hovered the mouse/pointer over the
Followingpane - scrolled using scroll wheel on mouse/trackpad, etc.
- when I reach the end of the list, I keep scrolling
Confirmed I was not able to accidentally scroll the background Brave News feed when scrolling either/both the Following pane or the Discover pane; also confirmed I was able to scroll the feed itself when hovered outside the Customize-dialog's UI
Issue 26306 / issue 26550 - PASSED
- installed
1.47.56 - launched Brave
- opened
brave://flags - toggled
brave://flags/#brave-news-v2toEnabled - clicked on
Relaunch - opened a new-tab page
- clicked
Customize - clicked
Turn on Brave News - beneath
Discover, enterhttps://planet.mozilla.org/atom.xml - clicked on
Get feeds from https://planet.mozilla.org/atom.xml - confirmed one
Planet Mozillaresult underSources - hovered over and click on the
Followbutton within - waited
- closed the dialog
- scrolled Brave News after a refresh
- confirmed I saw
Planet Mozillaarticles - returned to the
Customizedialog, and clickedUnfollow - confirmed the single feed source remained in the search UI
Confirmed I was subscribed to the Planet Mozilla feed, without duplicate sources/cards, via direct-feed search.
Follow feed in UI |
Brave News feed w/article |
Unfollow feed in UI |
|---|---|---|
 |
 |
 |
Issue 26266 - PASSED
- installed
1.47.56 - launched Brave
- clicked
Skip welcome tour - opened
brave://flags - set
brave://flags/#brave-news-v2toEnabled - set
brave://flags/#brave-news-subscribe-buttontoEnabled - clicked
Relaunch - opened a new-tab page
- loaded
planet.mozilla.org - clicked on
Manage Subscriptions - clicked on
Follow - opened a new-tab page
- scrolled down
- clicked
Show Brave News - clicked
Customize
Confirmed the Planet Mozilla favicon was to the left of its feed name, in the Following column
1.47.56 (fixed) |
1.46.100 (broken) |
|---|---|
 |
 |
This was referenced Nov 9, 2022
kjozwiak
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Uplift into 1.46.x approved 👍 QA has verified the PR on Nightly as per #15820 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift for #15818 which fixes brave/brave-browser#26271
Uplift for #15775 which fixes brave/brave-browser#26306 and brave/brave-browser#26550
Uplift for #15667 which fixes brave/brave-browser#26266