Remove hyphen(-) from os vpn entry

[simonhong]

We're seeing weird config write failure(#30291) on Windows.
Interestingly, it seems not happen on Stable.
One difference we found is non-stable's os entry name has hyphen(-), BraveVPN-Beta or BraveVPN-Nightly vs BraveVPN.
This is another test to check os entry name could affect config write failure or not.

STR

• Check that os entry name doesn't have hyphen like BraveVPNNightly, BraveVPNBeta

[kjozwiak]

The above requires 1.52.102 or higher for 1.52.x verification 👍

[stephendonner]

Verification PASSED using

Brave	1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	Windows 10 Version 22H2 (Build 19045.2965)

Steps:

1. installed 1.52.102 (beta)
2. launched Brave
3. purchased, configured, and tried to connect to Brave VPN
4. however, it fails to write out the config (due to Follow up to #29512 - Brave VPN Connect failed with Failed to write the VPN config #30291)
5. shut down Brave beta
6. launched Brave release
7. purchased, configured, and connected to Brave VPN
8. confirmed a BraveVPN entry was written to Windows' VPN settings page
9. disconnected from Brave VPN
10. relaunched 1.52.102
11. connected to Brave VPN

Confirmed I could connect to Brave VPN and an entry named BraveVPNBeta was written to the VPN settings page

step 4	step 7	step 8	step 11	vpn panel

[stephendonner]

Leaving final QA Pass-Win64 label for when @MadhaviSeelam gets a chance to verify on Windows 11 👍

[stephendonner]

Verified PASSED using

Brave	1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (x86_64)
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	macOS Version 13.4 (Build 22F66)

1. installed 1.52.102
2. launched Brave
3. purchased, configured, and connected to Brave VPN
4. opened Apple -> System Settings... -> VPN
5. confirmed entry of BraveVPNBeta

1.52.102	1.52.102	1.52.101

[MadhaviSeelam]

Verification PASSED using

Brave | 1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
-- | --
Revision | c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS | Windows 11 Version 22H2 (Build 22621.1702)

Steps:

1. installed 1.52.102 (beta)
2. launched Brave
3. purchased, configured, and tried to connect to Brave VPN
4. however, it fails to write out the config (due to Follow up to #29512 - Brave VPN Connect failed with Failed to write the VPN config #30291)
5. confirmed VPN entry is not shown in OS settings
6. shut down Brave beta
7. launched Brave release
8. purchased, configured, and connected to Brave VPN
9. confirmed a BraveVPN entry was written to Windows' VPN settings page
10. disconnected from Brave VPN
11. relaunched 1.52.102
12. connected to Brave VPN

Confirmed I could connect to Brave VPN and an entry named BraveVPNBeta was written to the VPN settings page

step 4	step 5	step 8	step 9	step 12	os settings/vpn panel