Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium 76 upgrade broke Clear Browsing Data dialog #5277

Closed
mkarolin opened this issue Jul 17, 2019 · 1 comment · Fixed by brave/brave-core#2945
Closed

Chromium 76 upgrade broke Clear Browsing Data dialog #5277

mkarolin opened this issue Jul 17, 2019 · 1 comment · Fixed by brave/brave-core#2945
Assignees
@mkarolin
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.67.x - Release

Comments

@mkarolin
Copy link
Contributor

Description

Clicking on clear browsing data in the settings results in no action.

Steps to Reproduce

  1. Open Brave
  2. Navigate to chrome://settings/privacy
  3. Click on "Clear browsing data"

Actual result:

Nothing happens.

Expected result:

Clear browsing data dialog pops up.

Reproduces how often:

Always.

Brave version (brave://version info)

Nightly (0.69.x)
@mkarolin mkarolin added this to the 0.69.x - Nightly milestone Jul 17, 2019
@mkarolin mkarolin self-assigned this Jul 17, 2019
@mkarolin mkarolin mentioned this issue Jul 17, 2019
Merged
32 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Jul 17, 2019
@mkarolin
Fix for Clear Browsing Data dialog not showing.
7ec1cf4 
Fixes brave/brave-browser#5277

Previously, each paper-tab was explicitly added in the html to
paper-tabs element. Now, cr-tabs element just needs tab names, which is done
in JS.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/6aea076147cf76991b848d4424c3f267ccd87679

commit 6aea076147cf76991b848d4424c3f267ccd87679
Author: Esmael El-Moslimany <aee@chromium.org>
Date:   Fri May 17 19:04:17 2019 +0000

    Settings WebUI: replace paper-tabs with cr-tabs

    Bug: 960564
This was referenced Jul 18, 2019
Merged
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 19, 2019 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description.
  • The issue was reproducible in 0.69.77
  • Verified all the items under chrome://settings/

Verification passed on

Brave 0.67.114 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description.
  • The issue was reproducible in 0.69.77
  • Verified all the items under chrome://settings/

Verified passed on

Brave 0.67.112 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Mac OS X
  • Verified the STR from the description.
  • The issue was reproducible in 0.69.77
  • Verified all the items under chrome://settings/

This was referenced Jul 19, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.67.x - Release
Development

Successfully merging a pull request may close this issue.

Fix for Clear Browsing Data dialog not showing. brave/brave-core
5 participants
@bsclifton @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin