Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover card shows chrome:// on brave:// pages (C78) #6385

Closed
bsclifton opened this issue Oct 9, 2019 · 1 comment · Fixed by brave/brave-core#3687
Closed

Hover card shows chrome:// on brave:// pages (C78) #6385

bsclifton opened this issue Oct 9, 2019 · 1 comment · Fixed by brave/brave-core#3687
Assignees
@mkarolin
Labels
branding feature/tabs-bar QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.70.x - Release

Comments

@bsclifton
Copy link
Member

Description

With Chromium 78, hover cards are enabled by default. When you move the mouse over a tab, it shows a bubble which has the title and some text.

When viewing brave:// pages, it'll show chrome:// in the hover card.

Related: #1973 and #3545

Steps to Reproduce

  1. Use a build which has Chromium 78
  2. Have a few tabs open
  3. Move your mouse over the different tabs

Actual result:

Screen Shot 2019-10-09 at 11 12 58 AM

Expected result:

URL shown should be brave://settings

Reproduces how often:

100%
@bsclifton bsclifton changed the title Hover card shows chrome:// on brave:// pages Hover card shows chrome:// on brave:// pages (C78) Oct 9, 2019
@bsclifton bsclifton mentioned this issue Oct 9, 2019
Closed
32 tasks
@mkarolin mkarolin self-assigned this Oct 12, 2019
@mkarolin mkarolin mentioned this issue Oct 12, 2019
Merged
32 tasks
@rebron rebron added 1.0 and removed 1.0-suggestion labels Oct 17, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Oct 17, 2019
@mkarolin
Fixes hover card bubble chrome:// urls.
defda68 
Fixes brave/brave-browser#6385

Replaces chrome:// scheme with brave:// in the hover card text.
Added a browser test to test the same.

Also, organized brave_browser_tests sources alphabetically in
test/BUILD.gn.
This was referenced Oct 17, 2019
Merged
Merged
Merged
@mkarolin mkarolin added this to the 0.73.x - Nightly milestone Oct 17, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Oct 21, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-21 at 9 46 41 AM

Screen Shot 2019-10-21 at 9 46 48 AM

Screen Shot 2019-10-21 at 9 47 58 AM

Verification passed on

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

image

image

image

image

Verification passed on

Brave 0.70.119 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

image

@rebron rebron removed the 1.0 label Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
branding feature/tabs-bar QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes hover card bubble chrome:// urls. brave/brave-core
6 participants
@bsclifton @rebron @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin