Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tor profile button now includes "private" (C78) #6451

Closed
bsclifton opened this issue Oct 11, 2019 · 2 comments · Fixed by brave/brave-core#3686
Closed

Tor profile button now includes "private" (C78) #6451

bsclifton opened this issue Oct 11, 2019 · 2 comments · Fixed by brave/brave-core#3686

Comments

@bsclifton
Copy link
Member

Description

I believe there is a chromium_src override that may be missing. In the profile button (shown at the top right, if you have more than one profile or are in a Tor window), it now has Private Tor (instead of just Tor)

Steps to Reproduce

  1. Use Nightly (0.72.x)
  2. Open a Tor window
  3. Look at profile button in top right

Actual result:

Screen Shot 2019-10-11 at 4 02 52 PM

Expected result:

Screen Shot 2019-10-11 at 4 03 04 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 0.72.90 Chromium: 78.0.3904.50 (Official Build) nightly (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.14.6 (Build 18G87)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n
  • Can you reproduce this issue with the beta channel? n
  • Can you reproduce this issue with the dev channel? n
  • Can you reproduce this issue with the nightly channel? y
@bsclifton bsclifton self-assigned this Oct 11, 2019
@mkarolin mkarolin self-assigned this Oct 12, 2019
@bsclifton bsclifton removed their assignment Oct 12, 2019
mkarolin added a commit to brave/brave-core that referenced this issue Oct 12, 2019
Also, removed no longer used override in chromium_src's profiles_state.cc.

Fixes brave/brave-browser#6451
@bsclifton
Copy link
Member Author

bsclifton commented Oct 16, 2019

Uplifted to 0.71.x with brave/brave-core#3693
Uplifted to 0.70.x with brave/brave-core#3695
Updated milestone to be 0.70.x 👍

@LaurenWags
Copy link
Member

LaurenWags commented Oct 17, 2019

Verified passed with

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)

Screen Shot 2019-10-17 at 12 01 58 PM

Verified passed with

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.70.118 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment