Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash reporting switch state not retained between relaunches #6496

Closed
GeetaSarvadnya opened this issue Oct 16, 2019 · 2 comments · Fixed by brave/brave-core#3718
Closed

Crash reporting switch state not retained between relaunches #6496

GeetaSarvadnya opened this issue Oct 16, 2019 · 2 comments · Fixed by brave/brave-core#3718
Assignees
@mkarolin
Labels
bug QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
0.70.x - Release

Comments

@GeetaSarvadnya
Copy link

Description

Crash reporting switch turned to OFF state after browser restart even though it's turned ON

Steps to Reproduce

  1. Clean profile 0.70.117
  2. Navigate to Additional settings under chrome://settings/
  3. Make sure Automatically send crash reports to brave switch is Turned OFF by default
  4. Click on the switch to make it ON (1st click doesn't do anything 2nd click makes switch enable)
  5. Click on Restart button
  6. Afte browser restart crash report switch is Turned OFF again

Actual result:

After browser restart, the switch is turned OFF
crash report toggle issue

Expected result:

After enabling toggle the switch Automatically send crash reports to brave should be in ON state after every browser restart

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? - The switch is turned ON by default
  • Can you reproduce this issue with the dev channel? - The switch is turned ON by default
  • Can you reproduce this issue with the nightly channel? Yes- reproduced

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @bsclifton @kjozwiak
@srirambv srirambv changed the title Crash reporting switch turned to OFF state after browser restart even though it's turned ON Crash reporting switch state not retained between relaunches Oct 16, 2019
@btlechowski
Copy link

Reproduced on Ubuntu 18.04

Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Linux

@mkarolin mkarolin self-assigned this Oct 16, 2019
@simonhong simonhong mentioned this issue Oct 16, 2019
Merged
32 tasks
@btlechowski btlechowski mentioned this issue Oct 16, 2019
Closed
@bsclifton bsclifton added this to the 0.70.x - Release milestone Oct 20, 2019
bsclifton pushed a commit to brave/brave-core that referenced this issue Oct 21, 2019
@bridiver @bsclifton
Fixes our use of GOOGLE_CHROME_BUILD
cf9cd47 
Fixes brave/brave-browser#6496
Fixes brave/brave-browser#6497

In places we reused GOOGLE_CHROME_BUILD by defining it in particular
files (either via chromium_src or by patching). GOOGLE_CHROME_BUILD is
being phased out in favor of BUILDFLAG(GOOGLE_CHROME_BRANDING). This fix
updates our uses where the transition has already occurred.

Chromium changes:

Overall issue tracker:
https://bugs.chromium.org/p/chromium/issues/detail?id=961769&can=2&q=961769

Some specific changes:

https://chromium.googlesource.com/chromium/src/+/0cc7112944131e379a141d8734a77cb50b97e1d5

commit 0cc7112944131e379a141d8734a77cb50b97e1d5
Author: Nico Weber <thakis@chromium.org>
Date:   Mon Jul 29 17:30:40 2019 +0000

    Add BUILDFLAG(GOOGLE_CHROME_BRANDING) and start using it in a few places.

    Also fix the definition of CHROMIUM_BRANDING; putting a negated condition
    there doesn't work. Thanks to Yngve Petterson for pointing that out.

    No behavior change.

    Bug: 961769

https://chromium.googlesource.com/chromium/src/+/356b304474c643e8064db763b97101100597bddd

commit 356b304474c643e8064db763b97101100597bddd
Author: Nico Weber <thakis@chromium.org>
Date:   Fri Aug 23 15:30:41 2019 +0000

    Remove all references to GOOGLE_CHROME_BUILD in components/

    Bug: 961769
This was referenced Oct 22, 2019
Merged
Merged
Merged
This was referenced Oct 22, 2019
Closed
Closed
Closed
@btlechowski
Copy link

btlechowski commented Oct 23, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified STR from the description.
Verified the ability to change the switch state.
Verified that the crash report was automatically sent to the server.

image

Verified passed with

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from the description.

Screen Shot 2019-10-23 at 9 32 48 AM

Screen Shot 2019-10-23 at 9 33 03 AM

  • Verified the ability to change the switch state.
  • Verified that the crash report was automatically sent to the server.
  • Confirmed crash report on stats

Screen Shot 2019-10-23 at 9 32 04 AM

Verification PASSED on Win 10 x64 using the following build:

Brave 0.70.121 Chromium: 78.0.3904.70 (Official Build) (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Windows 10 OS Version 1809 (Build 17763.805)

Annotation 2019-10-23 225157

Annotation 2019-10-23 225232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging a pull request may close this issue.

Update wrong GOOGLE_CHROME_BUILD usage brave/brave-core
6 participants
@kjozwiak @bsclifton @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin