Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox no longer appearing in list of browsers to import from #6521

Closed
LaurenWags opened this issue Oct 17, 2019 · 7 comments · Fixed by brave/brave-core#3837
Closed

Firefox no longer appearing in list of browsers to import from #6521

LaurenWags opened this issue Oct 17, 2019 · 7 comments · Fixed by brave/brave-core#3837
Assignees

Comments

@LaurenWags
Copy link
Member

Description

Updated my FF version and it no longer appears in the list of browsers to choose from for import in settings.

@kjozwiak has encountered this on macOS as well.

Steps to Reproduce

  1. Update/install/clean profile with FF 69.0.3
  2. Set up data (bookmarks, etc)
  3. Launch Brave
  4. Go to brave://settings/importData (either from Settings page or using macOS menu - Brave > Import Bookmarks and Settings).
  5. Firefox is not listed in drop down.

Actual result:

Screen Shot 2019-10-17 at 10 38 41 AM

Screen Shot 2019-10-17 at 10 24 59 AM

Note - Firefox does not appear in the list if it is closed either. Screenshot is just to show that Firefox is installed.

Expected result:

Firefox should be listed in the drop down.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)
Revision 416d6d8013e9adb6dd33b0c12e7614ff403d1a94-refs/branch-heads/3865@{#884}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.71.94 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? yes - 77.0.3865.120 (Official Build) (64-bit)

Miscellaneous Information:

cc @rebron @bsclifton @kjozwiak

cc @btlechowski @GeetaSarvadnya for other OSes

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 17, 2019

The issue is NOT reproducible in Windows 10 x64 - 0.70.117 and 0.69.135

image

@btlechowski
Copy link

Reproduced on Linux.

Brave 0.70.117 Chromium: 78.0.3904.50 (Official Build) (64-bit)
Revision 2accdc52c79976e264cd2694df6db31d1fccd8e8-refs/branch-heads/3904@{#658}
OS Linux

After installing the new version of FF 69.0.3, I got this message:
image

@rebron
Copy link
Collaborator

rebron commented Oct 22, 2019

@Brave-Matt for how many users this might be affecting?

@Brave-Matt
Copy link

@rebron still trying to discern how wide spread this is but I'm still getting reports of various Firefox data that does not get imported:
https://community.brave.com/t/not-import-from-firefox/88691

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix and removed 1.0-suggestion labels Oct 29, 2019
@iefremov iefremov self-assigned this Oct 30, 2019
@iefremov
Copy link
Contributor

Doesn't reproduce with
Brave | 0.73.41 Chromium: 78.0.3904.70 (Developer Build) (64-bit)

and FF 70 on linux

@iefremov
Copy link
Contributor

So apparently there are some different issues:

  1. Firefox is not visible in the list of browsers for import
  2. The user can start import, but something is not imported (mentioned in Community Firefox no longer appearing in list of browsers to import from #6521 (comment)).

Regarding the first problem, probably backporting this can help https://chromium.googlesource.com/chromium/src/+/5e3cc0612e21ce260f29cb702b0e83289f32cda2

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 21, 2019

Verified passed with

Brave 1.1.7 Chromium: 78.0.3904.108 (Official Build) beta (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description using Firefox 70.0.1.
  • Reproduced issue using 1.0.1 (currently released version) - FF was not available in import list

Screen Shot 2019-11-21 at 10 14 07 AM

Screen Shot 2019-11-21 at 10 14 20 AM

  • Upgraded profile to 1.1.7 and verified FF was now appearing in the list on both brave://welcome and brave://settings/importData.

Screen Shot 2019-11-21 at 10 20 32 AM

Screen Shot 2019-11-21 at 10 20 45 AM

Verification passed on

Brave 1.1.7 Chromium: 78.0.3904.108 (Official Build) beta (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS
  • Verified STR from description

image

Verification passed on

Brave 1.1.7 Chromium: 78.0.3904.108 (Official Build) beta (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants