-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brave constantly polling sites in the background, please stop. #8925
Comments
Yeah, and some of those requests to api.infura.io are big! |
I have also noticed this and honestly, I don't like it. I'm not using Crypto Wallet feature. |
@BrendanEich can we get some movement on this? |
@bsclifton Nope, it's constantly polling min-api.cryptocompare.com & api.infura.io (even if you're not visiting brave://wallets). Almost 1k requests daily: |
@snieg correct - I think just visiting the page once activates the extension (and the extension may be polling those URLs) Looks like @bbondy has a fix coming up with brave/brave-core#5513 😄 |
Moving to 1.10.x Beta as brave/brave-core#5624 is uplifted |
Verification PASSED on
Example:
QA also went through several cases re: lazy loading Crypto Wallets via #9757 (comment). Verification passed on
|
@srirambv let me know if there's anything else that needs to be checked that I might have missed with the above STR 👆 |
Verification passed on
Verification passed on
Verification passed on
|
@CHEF-KOCH can you please try Beta / Dev / Nightly channel? The fix is not in release channel yet. Will be in our next release (as confirmed by QA above). Thanks! 😄 |
Description
Brave is constantly polling:
and
Web3 provider for dapps is set to none.
If I browse to brave://wallet it loads the new wallet page, with hardware wallet connector options.
Steps to Reproduce
Intercept traffic with a web proxy.
Expected result:
To not constantly poll anything.
Brave version (brave://version info)
1.5.115 Chromium: 80.0.3987.149 (Official Build) (64-bit)
The text was updated successfully, but these errors were encountered: