Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load Brave Crypto Wallets (uplift to 1.10.x) #5624

Merged
merged 2 commits into from
May 26, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 22, 2020

Uplift of #5513

Why is this being requested for uplift?

This is being uplifted because of community complaints with backwards network traffic which occurs because of accidental installs.

This work makes it more explicit and also lazy loads things until an explicit action is taken.

It will also significantly decrease the Infura usage. We are currently above the highest package so would otherwise need to move to a custom plan.

If approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@bbondy
Copy link
Member

bbondy commented May 25, 2020

CI looks good. Only failure is an unrelated Rewards test fail:

BraveRewardsBrowserTest.NotVerifiedWallet

Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.10.x approved after deliberating with @brave/uplift-approvers. CI Failure relating to rewards which should not block the uplift.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants