Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto Wallets welcome screen content is not fully visible on smaller window sizes #6595

Closed
jhreis opened this issue Oct 24, 2019 · 3 comments · Fixed by brave/brave-core#5513

Comments

@jhreis
Copy link

jhreis commented Oct 24, 2019

Description

Using a view height of ~600px wallet info creation popup has some hidden content and the "I Understand" button is unreachable, as the content is not scrollable.

Steps to Reproduce

  1. Visit a Dapp
  2. Receive prompt to install wallet
  3. Install wallet
  4. Receive popup (see screenshot below), where some content is not visible (page is not scrollable)

Actual result:

Hidden content without ability to scroll:
hidden content

Expected result:

The ability to scroll and see all of the content.

  • Also, it seems odd that this has an "X" on it to dismiss...

Reproduces how often:

🤷‍♀ not easy to re-try AFAIK.

Brave version (brave://version info)

0.69.135

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? unknown
  • Can you reproduce this issue with the dev channel? unknown
  • Can you reproduce this issue with the nightly channel? unknown

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? unknown
  • Does the issue resolve itself when disabling Brave Rewards? unknown
  • Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

@srirambv
Copy link
Contributor

+1 from @SoaringMoon via #7825

@srirambv srirambv changed the title User wallet: Popup after creation can have hidden content if window is small Disclaimer popup isn't responsive when browser window is small Feb 11, 2020
@bbondy bbondy added this to the 1.11.x - Nightly milestone May 15, 2020
@srirambv
Copy link
Contributor

Moving to 1.10.x Beta as brave/brave-core#5624 is uplifted

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 27, 2020

Verification passed on


Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)


Verification passed on

Brave 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS
  • Verified the test plan from the description

image


Verified passed with

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-06-01 at 4 09 48 PM

@rebron rebron changed the title Disclaimer popup isn't responsive when browser window is small Crypto Wallets welcome screen content is not fully visible on smaller window sizes Jun 13, 2020
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants