Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebase when PRs move from draft to ready for review #20359

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

itschrishudson
Copy link
Contributor

@itschrishudson itschrishudson commented Jan 6, 2022

Resolves https://github.com/brave/devops/issues/6595
Creates an action that will perform a rebase when a PR is moved from draft to ready for review.
This is to trigger a fresh CI run (as we don't run CI against draft PRs) and ensure the PR is up to date before being reviewed and merged.
If the label CI/run-draft is present, it will not rebase as CI will have been run on pushes to the branch.
The rebase label is added as part of the action to give visibility to PR owners and reviewers this has taken place.

Submitter Checklist:

  • Confirms that no security/privacy review is needed, or that one has been requested
  • There is a ticket for this
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • All relevant documentation has been updated - at least here
  • Performed a self-review before removing WIP label
  • Asked for review from the right people

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • Major classes, functions and non-trivial code blocks are well-commented
  • Code follows the style guide
  • Plans below are specified in PR before merging
  • Branch being deployed from is protected in GitHub (PR approval required and no force push) - production only

Deploy Plan:

  • N/A

Rollback Plan:

  • N/A

Test Plan:

  • N/A

This change has been deployed to:

  • development
  • staging
  • production (tag @channel in #prod-changes if this may have wider impact)
  • N/A

@itschrishudson itschrishudson self-assigned this Jan 6, 2022
@itschrishudson itschrishudson marked this pull request as ready for review January 6, 2022 15:12
@github-actions github-actions bot added rebase and removed rebase labels Jan 6, 2022
@itschrishudson itschrishudson merged commit d405eaa into master Jan 6, 2022
@itschrishudson itschrishudson deleted the 6595-trigger-rebase-on-pr-ready branch January 6, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants