Remove unused lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl from locally persisted Brave Ads state

[tmancey]

Remove unused lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl from locally persisted (Default/ads_service/client.json) Brave Ads state

[GeetaSarvadnya]

Verification passed on

Brave | 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Remove unused lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl from locally persisted Brave Ads state brave-core#5159
• Reproduced in 1.8. 95 - lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl are persisted in Default/ads_service/client.json
• ensured that lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl are NOT persisted in Default/ads_service/client.json in 1.9.x
• ensured that lastUserActivity, lastUserIdleStopTime, and lastPageClassification fields are also removed from 1.9.x

{
  "adPreferences": {
    "filtered_ads": [],
    "filtered_categories": [],
    "saved_ads": [],
    "flagged_ads": []
  },
  "adsShownHistory": [],
  "purchaseIntentSignalHistory": {},
  "adUUID": "30915544-c707-4a94-aa05-77e03cae3c73",
  "adsUUIDSeen": {},
  "advertisersUUIDSeen": {},
  "nextCheckServeAd": 0,
  "available": true,
  "userModelLanguage": "en",
  "userModelLanguages": [
    "de",
    "en",
    "fr"
  ],
  "pageScoreHistory": [],
  "creativeSetHistory": {},
  "adConversionHistory": {},
  "campaignHistory": {},
  "score": 0,
  "version_code": ""
}

---

Verified passed with

Brave | 1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)

• Verified test plan from Remove unused lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl from locally persisted Brave Ads state brave-core#5159

• Verified for clean and upgrade profiles

• Confirmed with @tmancey that additional fields missing from client.json when compared with client.json from 1.8.x are expected. These other fields which should be removed are: lastUserActivity, lastUserIdleStopTime, and lastPageClassification.

on the left is client.json from 1.8.95 and on the right is same client.json from 1.9.62:

---

Verification passed on

Brave	1.9.62 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Remove unused lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl from locally persisted Brave Ads state brave-core#5159
• Reproduced in 1.8. 95 - lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl are persisted in Default/ads_service/client.json
• ensured that lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl are NOT persisted in Default/ads_service/client.json in 1.9.x

{
	"adPreferences": {
		"filtered_ads": [],
		"filtered_categories": [],
		"saved_ads": [],
		"flagged_ads": []
	},
	"adsShownHistory": [],
	"purchaseIntentSignalHistory": {},
	"adUUID": "77dc8a4e-4b83-45fc-879c-8743d7f2982e",
	"adsUUIDSeen": {},
	"advertisersUUIDSeen": {},
	"nextCheckServeAd": 0,
	"available": true,
	"userModelLanguage": "en",
	"userModelLanguages": ["de", "en", "fr"],
	"pageScoreHistory": [],
	"creativeSetHistory": {},
	"adConversionHistory": {},
	"campaignHistory": {},
	"score": 0.0,
	"version_code": ""
}