Remove unused lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl from locally persisted Brave Ads state #5159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diracdeltas
reviewed
Apr 6, 2020
| @@ -700,13 +697,11 @@ void AdsImpl::OnPageLoaded( | |||
| return; | |||
| } | |||
|
|
|||
| if (TestSearchState(url)) { | |||
| if (SearchProviders::IsSearchEngine(url)) { | |||
| BLOG(INFO) << "Site visited " << url << ", URL is a search engine"; | |||
There was a problem hiding this comment.
should the URL even be logged? logs can get persisted to disk unintentionally
There was a problem hiding this comment.
yea, this seems like it should be a VLOG entry anyway if we kept it at all. INFO doesn't seem like the right logging level even without the persistence issue
diracdeltas
approved these changes
Apr 6, 2020
bridiver
reviewed
Apr 6, 2020
| @@ -21,12 +20,7 @@ | |||
| "adUUID": "", | |||
| "locale": "en", | |||
| "lastUserActivity": 0, | |||
There was a problem hiding this comment.
can we clear this from existing state or does that happen somewhere that I missed?
bridiver
approved these changes
Apr 6, 2020
…, shopActivity and shopUrl from locally persisted Brave Ads state
NejcZdovc
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#9022
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm lastSearchTime, searchActivity, searchUrl, lastShopTime, shopActivity and shopUrl are not persisted in
Default/ads_service/client.jsonReviewer Checklist:
After-merge Checklist:
changes has landed on.