Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog URL is incorrect #9415

Closed
leonschmidlin opened this issue Apr 23, 2020 · 3 comments · Fixed by brave/brave-core#5519
Closed

Changelog URL is incorrect #9415

leonschmidlin opened this issue Apr 23, 2020 · 3 comments · Fixed by brave/brave-core#5519

Comments

@leonschmidlin
Copy link

leonschmidlin commented Apr 23, 2020

Test plan

  1. Do install as non-admin user on macOS for an older version of Brave, as described in Software update popup should not be presented during Sparkle update process #9562 (comment)
  2. Check for updates
  3. URL shown in update modal should be correct

Description

The Brave Software Update prompt shows the old changelog URL "https://github.com/brave/brave-browser/blob/master/CHANGELOG.md" instead of the new "CHANGELOG_DESKTOP.md" or "CHANGELOG_ANDROID.md".

Steps to Reproduce

Get a Brave Software update prompt on update and try to open the link, "CHANGELOG.md" does not exist.
Try to open the URL of changelog_url in brave-core/script/lib/omaha.py.

Actual result:

Screenshot 2020-04-23 at 14 03 06

Expected result:

Adjusted URL to the respective changelog.

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave | 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision | e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS | macOS Version 10.15.4 (Build 19E287)

Version/Channel Information:

Current release

@Waldbaer88
Copy link

Waldbaer88 commented May 8, 2020

Just wanted to say that this problem is really obvious because of the apps frequent updates. I'm using it on MacOS and there, the (false) link is not even rendered but just shown as plain HTML code.
Bildschirmfoto 2020-05-08 um 12 42 35
Should be quite easy to fix, isn't it?

EDIT: Just found the bad formatting as a seperate issue here: #9274

@mbacchi
Copy link
Contributor

mbacchi commented May 11, 2020

We'll update the URL shortly, and hopefully get the link rendered too while we're at it. Thanks for the report!

@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2020

Verification PASSED on macOS 10.13.6 High Sierra x64 using the following build:

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.13.6 (Build 17G11023)

Screen Shot 2020-06-02 at 5 56 18 PM

Verification PASSED on macOS 10.15.5 Catalina x64 using the following build:

Brave | 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.15.5 (Build 19F101)

Screen Shot 2020-06-02 at 10 33 25 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment