Implement pagination for publisher list #9607

NejcZdovc · 2020-05-04T07:12:00Z

Test plan

See brave/brave-core#5458

Description

Resolves brave/brave-browser#9607

LaurenWags · 2020-05-12T12:55:26Z

Verified passed with

Brave	1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from Adds pagination to publisher list brave-core#5458
Confirmed for both staging and production
Confirmed able to see various publisher types as verified (regular sites, YouTube, GitHub, Twitch, Reddit, Vimeo, Twitter)
Confirmed able to see custom publisher banners (where applicable)
Confirmed Refresh Status link in panel re-downloads the publisher list

Verification passed on

Brave	1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision	8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS	Linux

Verified on both staging and production
Verified all publishers type shows(Website/YT/GH/Twitch/Reddit/Vimeo/Twitter) up as verified in BR panel
Verified custom banner shown for enabled publishers
Verified clicking on Refresh Status link downloads 8 pages of pub info as shown here in log (prod wallet)

Prod wallet log with pagination details

[25033:25033:0512/053706.045100:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=1
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053706.502939:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290626
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 3717523
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:34:13 GMT
headers etag: W/"770f17b968dd37464db77903d286e70d"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: fa4262a7-71ba-423b-b40f-f4ad0bb6315b
headers x-runtime: 0.736669
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25034:1:0512/053712.626583:INFO:ads_impl.cc(479)] OnTabUpdated.IsBlurred for tab id: 2 and url: chrome://welcome/
[25034:1:0512/053712.628982:INFO:ads_impl.cc(479)] OnTabUpdated.IsBlurred for tab id: 3 and url: chrome://rewards/
[25034:1:0512/053712.634877:INFO:ads_impl.cc(479)] OnTabUpdated.IsBlurred for tab id: 4 and url: http://pdf995.com/
[25001:25001:0512/053712.655545:INFO:ads_service_impl.cc(2139)] AdsService Event Log: {"data":{"type":"blur","timestamp":"2020-05-12T05:37:12Z","tabId":2}}
[25001:25001:0512/053712.664568:INFO:ads_service_impl.cc(2139)] AdsService Event Log: {"data":{"type":"blur","timestamp":"2020-05-12T05:37:12Z","tabId":3}}
[25001:25001:0512/053712.668555:INFO:ads_service_impl.cc(2139)] AdsService Event Log: {"data":{"type":"blur","timestamp":"2020-05-12T05:37:12Z","tabId":4}}
[25001:25001:0512/053712.670421:INFO:ads_service_impl.cc(2139)] AdsService Event Log: {"data":{"type":"background","timestamp":"2020-05-12T05:37:12Z"}}
[25034:1:0512/053712.672040:INFO:client.cc(668)] Successfully saved client state
[25034:1:0512/053712.679706:INFO:client.cc(668)] Successfully saved client state
[25034:1:0512/053712.711439:INFO:client.cc(668)] Successfully saved client state
[25033:25033:0512/053713.099861:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=2
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053713.239125:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290633
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 3270216
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:34:34 GMT
headers etag: W/"6d05c76cebc3a3de2e1ba676afdbf0ba"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: 5ae95897-d61b-4654-9df0-44214e15a3d9
headers x-runtime: 0.641746
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25033:25033:0512/053715.258292:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=3
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053715.378106:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290635
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 3268949
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:34:41 GMT
headers etag: W/"280383ac0103d3e95d36acc5b9e92426"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: d35ef478-a1c1-4f13-8e92-79a325b38959
headers x-runtime: 1.091174
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25033:25033:0512/053718.431508:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=4
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053718.531580:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290638
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 3262911
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:34:47 GMT
headers etag: W/"b202f97b3ad73521227490637494a33a"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: b073b7c2-088e-4299-86ec-4c189a6ba3e1
headers x-runtime: 0.488129
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25033:25033:0512/053720.778390:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=5
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053720.885143:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290640
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 3018177
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:34:54 GMT
headers etag: W/"995001f333717a6f03bd5326673b29ec"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: 16c9872a-f58a-4836-b9b1-3e72aacf3cc7
headers x-runtime: 1.759052
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25033:25033:0512/053722.606830:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=6
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053722.702830:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290642
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 2199024
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:35:01 GMT
headers etag: W/"79475caf3408525487293813e0dd3842"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: 4e0089b2-cf67-4695-83e0-29f9d7f471cf
headers x-runtime: 0.409496
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25034:1:0512/053722.813044:INFO:ads_impl.cc(349)] Browser state changed to idle
[25033:25033:0512/053723.933566:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=7
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053723.994776:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290643
result: Success
http code: 200
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers age: 0
headers cache-control: max-age=3600, public
headers content-encoding: gzip
headers content-length: 1517969
headers content-type: application/json; charset=utf-8
headers date: Tue, 12 May 2020 13:35:07 GMT
headers etag: W/"9f64d592712e4101cf3d5b8aa0a93a48"
headers server: Cowboy
headers status: 200
headers vary: Accept-Encoding
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: 6346d0c1-a9a8-4094-9fed-843a0210b3d7
headers x-runtime: 0.284187
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]
[25033:25033:0512/053724.698276:VERBOSE1:ledger_impl.cc(443)]
[ REQUEST ]
url: https://publishers-distro.basicattentiontoken.org/api/v3/public/channels?page=8
method: UrlMethod::GET
content:
contentType:
header: Accept-Encoding: gzip
[ END REQUEST ]
[25033:25033:0512/053724.699908:VERBOSE1:ledger_impl.cc(940)]
[ RESPONSE - OnDownload ]
time: 1589290644
result: Success
http code: 204
response: Publisher list
headers accept-ranges: bytes
headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
headers access-control-allow-methods: GET
headers access-control-allow-origin: https://rewards.bravesoftware.com
headers access-control-request-method: GET
headers cache-control: max-age=3600, public
headers date: Tue, 12 May 2020 13:35:10 GMT
headers server: Cowboy
headers status: 204
headers via: 1.1 varnish
headers x-cache: MISS
headers x-cache-hits: 0
headers x-frame-options: deny
headers x-request-id: 54c14743-713a-4cd0-b3c3-c15b852208d1
headers x-runtime: 0.024923
headers x-served-by: cache-yul8923-YUL
[ END RESPONSE ]

Verification passed on


Brave | 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from Adds pagination to publisher list brave-core#5458
Confirmed for both staging and production
Confirmed able to see various publisher types as verified (regular sites, YouTube, GitHub, Twitch, Reddit, Vimeo, Twitter)
Confirmed able to see custom publisher banners (where applicable)
Confirmed Refresh Status link in panel re-downloads the publisher list

[ REQUEST ]
> url: https://publishers-staging-distro.basicattentiontoken.org/api/v3/public/channels?page=1
> method: UrlMethod::GET
> content: 
> contentType: 
> header: Accept-Encoding: gzip
[ END REQUEST ]
[ RESPONSE - OnDownload ]
> time: 1589292411
> result: Success
> http code: 200
> response: Publisher list
> headers accept-ranges: bytes
> headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
> headers access-control-allow-methods: GET
> headers access-control-allow-origin: https://rewards-stg.bravesoftware.com
> headers access-control-request-method: GET
> headers age: 858
> headers cache-control: max-age=3600, public
> headers content-encoding: gzip
> headers content-length: 3344600
> headers content-type: application/json; charset=utf-8
> headers date: Tue, 12 May 2020 14:06:50 GMT
> headers etag: W/"43e4d23370c37ddf9e29a3630d8e3364"
> headers server: Cowboy
> headers status: 200
> headers strict-transport-security: max-age=31536000; includeSubDomains
> headers vary: Accept-Encoding
> headers via: 1.1 varnish
> headers x-cache: HIT
> headers x-cache-hits: 1
> headers x-frame-options: deny
> headers x-request-id: 619a7d68-6fac-44da-a05b-52f80432413c
> headers x-runtime: 1.435167
> headers x-served-by: cache-bom18225-BOM
[ END RESPONSE ]

Verification PASSED on macOS 10.15.4 x64 using the following build:

Brave | 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.15.4 (Build 19E287)

Verified test plan from Adds pagination to publisher list brave-core#5458
Confirmed for both staging and production
Confirmed able to see various publisher types as verified (regular sites, YouTube, GitHub, Twitch, Reddit, Vimeo, Twitter)
Confirmed able to see custom publisher banners (where applicable)
Confirmed Refresh Status link in panel re-downloads the publisher list

SephReed · 2020-05-13T03:18:26Z

Still getting BAT ledger 100% issues.

NejcZdovc · 2020-05-13T05:34:11Z

@SephReed thank you for the update, my guess is that what will fix it for you is this one #7595 which is in Nightly currently

victorelec14 · 2020-05-24T16:29:57Z

it's still happening.

Version 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)

NejcZdovc added the feature/rewards label May 4, 2020

NejcZdovc self-assigned this May 4, 2020

NejcZdovc mentioned this issue May 4, 2020

Adds pagination to publisher list brave/brave-core#5458

Merged

32 tasks

NejcZdovc added the QA/Yes label May 5, 2020

bsclifton added this to the 1.10.x - Nightly milestone May 5, 2020

bsclifton added QA/Test-Plan-Specified release-notes/include labels May 5, 2020

NejcZdovc added a commit to brave/brave-core that referenced this issue May 6, 2020

Adds pagination to publisher list

e777715

Resolves brave/brave-browser#9607

NejcZdovc closed this as completed in brave/brave-core#5458 May 6, 2020

NejcZdovc added a commit to brave/brave-core that referenced this issue May 6, 2020

Adds pagination to publisher list

0a8e821

Resolves brave/brave-browser#9607

NejcZdovc mentioned this issue May 6, 2020

Adds pagination to publisher list (uplift to 1.9.x) brave/brave-core#5471

Merged

4 tasks

NejcZdovc added a commit to brave/brave-core that referenced this issue May 6, 2020

Adds pagination to publisher list

bfc3a42

Resolves brave/brave-browser#9607

This was referenced May 6, 2020

Adds pagination to publisher list (uplift to 1.8.x) brave/brave-core#5472

Merged

"Bat Ledger Service" causing 100% CPU usage #8846

Closed

Bat Ledger Service uses 99% of CPU #8691

Closed

bsclifton pushed a commit to brave/brave-core that referenced this issue May 11, 2020

Adds pagination to publisher list

2f18ed3

Resolves brave/brave-browser#9607

bsclifton pushed a commit to brave/brave-core that referenced this issue May 11, 2020

Adds pagination to publisher list

14de590

Resolves brave/brave-browser#9607

kjozwiak modified the milestones: 1.10.x - Nightly, 1.9.x - Beta May 11, 2020

kjozwiak mentioned this issue May 11, 2020

[Android] Implement pagination for publisher list #9724

Closed

bsclifton removed this from the 1.9.x - Beta milestone May 12, 2020

bsclifton added this to the 1.8.x - Release Hotfix 3 milestone May 12, 2020

LaurenWags added the QA Pass-macOS label May 12, 2020

srirambv added the QA Pass-Linux label May 12, 2020

GeetaSarvadnya added the QA Pass-Win64 label May 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement pagination for publisher list #9607

Implement pagination for publisher list #9607

NejcZdovc commented May 4, 2020 •

edited by bsclifton

Loading

LaurenWags commented May 12, 2020 •

edited by kjozwiak

Loading

SephReed commented May 13, 2020

NejcZdovc commented May 13, 2020

victorelec14 commented May 24, 2020

Implement pagination for publisher list #9607

Implement pagination for publisher list #9607

Comments

NejcZdovc commented May 4, 2020 • edited by bsclifton Loading

Test plan

Description

LaurenWags commented May 12, 2020 • edited by kjozwiak Loading

SephReed commented May 13, 2020

NejcZdovc commented May 13, 2020

victorelec14 commented May 24, 2020

NejcZdovc commented May 4, 2020 •

edited by bsclifton

Loading

LaurenWags commented May 12, 2020 •

edited by kjozwiak

Loading