Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

May ads payout recovery #9684

Closed
NejcZdovc opened this issue May 8, 2020 · 1 comment · Fixed by brave/brave-core#5495
Closed

May ads payout recovery #9684

NejcZdovc opened this issue May 8, 2020 · 1 comment · Fixed by brave/brave-core#5495

Comments

@NejcZdovc
Copy link
Contributor

We should preform one time check on user ad promotion and if it's in the bad state because of empty public key recover from it.

@NejcZdovc NejcZdovc self-assigned this May 8, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue May 8, 2020
@NejcZdovc NejcZdovc added this to the 1.10.x - Nightly milestone May 8, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue May 11, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue May 11, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue May 11, 2020
@LaurenWags
Copy link
Member

LaurenWags commented May 12, 2020

Verified passed with

Brave | 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified the test plan from Adds recovery path for may payout problem brave-core#5495.
  • Confirmed putting the browser into a broken state with 1.8.95 in both cases.
  • Launched broken profiles with 1.8.96 and confirmed balances displayed as expected.
  • Confirmed able to tip in both cases after launching with 1.8.96.
  • For test case 2, confirmed request to /promotions/reportclobberedclaims in terminal.
[ REQUEST ]
> url: https://grant.rewards.bravesoftware.com/v2/promotions/reportclobberedclaims
> method: UrlMethod::POST
> content: {"claimIds":["5fb28bd9-fb0d-45da-a1eb-47cdeea27913"]}
> contentType: application/json; charset=utf-8
[ END REQUEST ]

Verification passed on

Brave 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified profile goes into broken state on 1.8.95 and BR panel shows 0.0.BAT

Screen Shot 2020-05-12 at 8 10 26 PM

  • Verified upgrading to 1.8.96 updates the balance correctly

Screen Shot 2020-05-12 at 8 11 11 PM

  • Verified able to tip publisher after upgrading to 1.8.96
  • Verified balance updates correctly after tipping a verified pub
  • Verified logs shows /promotions/reportclobberedclaims
    image
  • Verified promotion status is set to 6
    image
  • Verified creds_batch status is set to 5
    image

Verification passed on

Brave | 1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified profile goes into broken state on 1.8.95 and BR panel shows 0.0.BAT
    image

  • Verified upgrading to 1.8.96 updates the balance correctly
    image

  • Verified able to tip publisher after upgrading to 1.8.96

  • Verified balance updates correctly after tipping a verified pub

  • Verified logs shows /promotions/reportclobberedclaims
    Case 2:

[ REQUEST ]
> url: https://grant.rewards.bravesoftware.com/v2/promotions/reportclobberedclaims
> method: UrlMethod::POST
> content: {"claimIds":["99388427-246d-4889-b907-7a6eda4d5988"]}
> contentType: application/json; charset=utf-8
[ END REQUEST ]
  • Verified promotion status is set to 6
    image

  • Verified creds_batch status is set to 5
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment