Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 83.0.4103.61 to Chromium 83.0.4103.97 (1.10.x). #10183

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Jun 9, 2020

Fixes #10075
Related PR: brave/brave-core#5789
Uplift from #10076

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade from Chromium 83.0.4103.61 to Chromium 83.0.4103.97.
@kjozwiak
Copy link
Member

Looks like both test-browser and test-install failed on macOS as per the following:

17:39:30  [  FAILED  ] BraveRewardsBrowserTest.CheckIfReconcileWasResetEmpty, where TypeParam =  and GetParam() =  (31021 ms)
17:39:30  [568/568] BraveRewardsBrowserTest.CheckIfReconcileWasResetEmpty (31151 ms)
17:39:30  1 test failed:
17:39:30      BraveRewardsBrowserTest.CheckIfReconcileWasResetEmpty (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2941)

However, these are known issues and not blockers.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.10.x approved after deliberating with @brave/uplift-approvers. As per #10183 (comment), the failures on CI are known issues and not blocking uplift.

@kjozwiak kjozwiak merged commit 9b36c85 into 1.10.x Jun 10, 2020
@kjozwiak kjozwiak deleted the 83.0.4103.97-1.10.x branch June 10, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants