Add build_omaha option to create_dist command #1800
Conversation
|
@simonhong when this is ready for review, it would be great to understand what arguments get passed in for tagging? 😄 |
|
@bsclifton Oh,, I didn't consider tagging process for this sub-command :) This sub-command should receive tagging infos together. |
|
@simonhong not sure I follow - how does it know what the product guid / channel are? Those are required for creating the stub installer, right? |
|
@bsclifton I got needed information from https://github.com/brave/brave-core/pull/722/files#diff-a1d6e4460dc2ec6f82e6a22b56c1bbd8R46 and it is passed to |
simonhong
force-pushed
the
build_omaha_sub_command_in_create_dist
branch
from
52ac366
to
2d28de9
Compare
Build omaha stub/standalone installer when --build_omaha option is passed to create_dist command. Also, tag_ap should be passed for tagging.
simonhong
force-pushed
the
build_omaha_sub_command_in_create_dist
branch
from
2d28de9
to
3364408
Compare
simonhong
changed the title
| @@ -82,6 +84,7 @@ Config.prototype.buildArgs = function () { | |||
| brave_version_minor: version_parts[1], | |||
| brave_version_build: version_parts[2], | |||
| chrome_version_string: this.chromeVersion, | |||
| chrome_version_major: chrome_version_parts[0], | |||
There was a problem hiding this comment.
During the installer build, different style of brave full version is used like 70.0.58.1 or 70_0_58_1.
To make these strings easily in gn, pass chromium's major version number.
simonhong
changed the title
…_dist Add build_omaha option to create_dist command
…_dist Add build_omaha option to create_dist command
Build omaha stub/standalone installer when --build_omaha option is
passed to create_dist command. Also, tag_ap should be passed for tagging.
This new
bulid_omahaoption will create five additional executables inout/Release/Also, we can see UAC prompt at the start of omaha build because omaha can be built with admin mode.
For example, when we run
yarn create_dist Release --build_omaha --channel=beta --tag_ap=x64-be, it will create five more executables inout/Release(in this case 70.0.58.1) like below.brave_installer_70_0.58_1.exeBraveBrowserBetaSetup_70_0_58_1.exeDebugBraveBrowserBetaSetup_70_0_58_1.exeBraveBrowserStandaloneBetaSetup_70_0_58_1.exeDebugBraveBrowserStandaloneBetaSetup_70_0_58_1.exeBefore trying to build omaha with this new option, please try to build omaha in vendor/omaha first.
Omaha needs more additional build environment setup.
This new option doesn't affect existing behavior.
Close #1784
Issue Issue: #688
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: