Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adblock-rust test path #5027

Merged
merged 1 commit into from
Jun 24, 2019
Merged

Fix adblock-rust test path #5027

merged 1 commit into from
Jun 24, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 24, 2019

Fix #4793
Sister PR: brave/brave-core#2569

There's a race condition if you try to use the same gn rule, so I had to make it separate.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

There's a race condition if you try to use the same rule, so I had to make it separate
@bbondy bbondy added the CI/skip label Jun 24, 2019
@bbondy bbondy requested a review from tmancey June 24, 2019 12:35
@bbondy bbondy self-assigned this Jun 24, 2019
Copy link
Contributor

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@bbondy bbondy merged commit 796a12a into master Jun 24, 2019
@mihaiplesa mihaiplesa added this to the 0.68.x - Nightly milestone Jun 24, 2019
@mihaiplesa mihaiplesa deleted the adblock-rust-ffi branch June 24, 2019 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new adblock-rust library
3 participants