Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 #6311

Closed
wants to merge 6 commits into from

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Oct 3, 2019

Fixes #6067
Related PR brave/brave-core#3600

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 0.72.x - Nightly milestone Oct 3, 2019
@mkarolin mkarolin self-assigned this Oct 3, 2019
@mkarolin mkarolin changed the title Update from Chromium 77.0.3865.75 to Chromium 78.0.3904.44 Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 Oct 4, 2019
@mkarolin mkarolin force-pushed the 78.0.3904.44 branch 4 times, most recently from f3a1a9e to 603081d Compare October 7, 2019 21:51
@mkarolin mkarolin changed the title Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 WIP: Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 Oct 8, 2019
@mkarolin mkarolin marked this pull request as ready for review October 8, 2019 16:27
mkarolin and others added 6 commits October 8, 2019 12:31
We could update CI to download/unzip/install the CDM binaries (header, manifest, etc)... but that would only be appropriate if we wanted to bundle CDM. We don't intend to bundle Widevine, instead we are distributing using component updater.

Stub needed after Chromium change:

https://chromium.googlesource.com/chromium/src/+/90c6eb5176bf1347001dde9edd27aa8b70b74186

commit 90c6eb5176bf1347001dde9edd27aa8b70b74186
Author: John Rummell <jrummell@chromium.org>
Date:   Thu Aug 29 21:07:24 2019 +0000

    Move CDMs into platform specific paths on Linux

    Rather than including the CDMs in the base install directory, move them
    into subdirectories (e.g. Widevine would be located in
    <installdir>/WidevineCdm/_platform_specific/linux_x64/libwidevinecdm.so).
    This allows the LICENSE and manifest.json file to be bundled with Chrome
    on Linux. Future CL's will use the manifest.json file to determine
    the capabilities of the CDM (rather than having them hardcoded as they
    are today).

    In addition to the unittests below, ran EME browser_tests (both ECK
    and Widevine) to check that the library can be loaded from it's new
    directory, and built "installer" (although I don't know if whatever
    package it creates is installable).

    Bug: 971433
Chromium change:

https://chromium.googlesource.com/chromium/src/+/9797cc66ad6e9987f00272120835b840d7c132b5

commit 9797cc66ad6e9987f00272120835b840d7c132b5
Author: Hector Carmona <hcarmona@chromium.org>
Date:   Fri Aug 9 20:35:35 2019 +0000

    [Reland] Navi: Remove usage of 'Onboarding' most places in welcome code.

    Bug: 986979
Chromium change:

https://chromium.googlesource.com/chromium/src/+/8959d58944bda5168d522fc7bd4cb232b615a05a

commit 8959d58944bda5168d522fc7bd4cb232b615a05a
Author: Tommy Steimel <steimel@chromium.org>
Date:   Wed Aug 7 17:53:52 2019 +0000

    GMC: Add tooltip text to toolbar icon

    This CL adds tooltip text to the global media controls toolbar icon.

    Bug: 991271
Chromium change:

https://chromium.googlesource.com/chromium/src/+/2c1f2716ee49f77272c3a986b9caee86ae3430c7

commit 2c1f2716ee49f77272c3a986b9caee86ae3430c7
Author: yilkal <yilkal@chromium.org>
Date:   Wed Aug 14 16:21:25 2019 +0000

    Move supervised user strings to chrome/app.

    Moved supervised_user_error_page_strings.grdp,
    supervised_user_error_page_strings_grdp/ to chrome/app/.

    This is to resolve translation extraction failure for chrome
    client project.

    Updated references in chrome/app/generated_resources.grd

    Bug: 993353
@bsclifton bsclifton changed the title WIP: Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 Update from Chromium 77.0.3865.90 to Chromium 78.0.3904.44 Oct 9, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here LGTM 👍

@mkarolin
Copy link
Contributor Author

Closing in favor of #6396

@mkarolin mkarolin closed this Oct 10, 2019
@bsclifton bsclifton deleted the 78.0.3904.44 branch October 10, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 77.0.3865.90 to Chromium 78.0.3904.50
2 participants