Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SiteRemovalNotification is always visible when reloading #1194

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 1, 2019

SiteRemovalNotification in NTP should be hidden after reloading or
restart.
To fix this, ctor of NewTabPage component hides it.

Fix brave/brave-browser#2772

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Remove thumb in NTP
  2. Reloading, creating new tab instance and browser restart
  3. Check thumb removed notification isn't visible

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@simonhong simonhong self-assigned this Jan 1, 2019
SiteRemovalNotification in NTP should be hidden after reloading or
restart.
To fix this, ctor of NewTabPage component hides it.
@simonhong simonhong force-pushed the fix_site_removal_notification branch from b6d52e9 to 1c2d6aa Compare January 1, 2019 07:16
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks Simon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SiteRemovalNotification doesn't disappear w/o explicit user closing
3 participants