Tab separator becomes 1dp wide #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
approved these changes
Jan 24, 2019
bridiver
reviewed
Jan 31, 2019
| SK_AlphaOPAQUE)); | ||
| }; | ||
|
|
||
| + const int separator_radius = separator_bounds.leading.width() / 2; | ||
| + // Even if |separator_radius| becomes 1 native pixel the 'roundedness' |
There was a problem hiding this comment.
we should avoid comments in patches. Any info should be in the commit message or PR and can be found with git blame
There was a problem hiding this comment.
I'm ok either way but just noting that I don't think it costs extra time to rebase because of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#3081
I kept the patch in for drawing the separators with rounded rectangles because, although extremely subtle, it matches the similar strategy for other separators in Brave (e.g. brave actions bar in location bar).
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: