Temporarily disable Windows network diagnostic button; permanently disable DNS diagnostic probes #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick fix brave/brave-browser#3249; can revert once https://bugs.chromium.org/p/chromium/issues/detail?id=929141 is fixed. Test plan (windows only) 1. Go to a non-existent site like dklfjdkafjdkafj.com 2. You should not see a button that says 'Running Windows Network Diagnostics'
|
chromium already opened a fix: https://chromium.googlesource.com/chromium/src.git/+/e005fff9c838a13ff1402b01617adca691187a6b we may want to just use that instead (cherry-pick into next release) |
These probes should already be disabled by default because kAlternateErrorPagesEnabled is false by default in Brave. This patch makes it impossible to enable these probes, since they could cause Tor leaks. partial fix brave/brave-browser#3249
diracdeltas
changed the title
|
going to redo this using the upstream commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1st commit:
quick fix for brave/brave-browser#3249;
however this is fixed upstream in https://chromium.googlesource.com/chromium/src.git/+/e005fff9c838a13ff1402b01617adca691187a6b%5E%21/; we may just want to cherry-pick that commit? not sure if we have a procedure for doing that. I don't think we want to wait for Chromium 74 in order to get this fix out given the impact on Tor.
2nd commit:
defense in depth to ensure DNS probes are disabled
Test plan (windows only)
Diagnostics'
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: