Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign Copy keyboard shortcut to 'copy clean link' (Mac App Menu part) #16746

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Assign Copy keyboard shortcut to 'copy clean link' (Mac App Menu part) #16746

merged 1 commit into from
Jan 21, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jan 19, 2023 •
edited
Loading

Resolves brave/brave-browser#27902

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Select url in address bar and check Mac App menu -> Edit -> Copy clean link has cmd+C hotkey
  • Check that if no url selected in the address bar, Mac App menu -> Edit works default way, no Copy clean link item visible

@spylogsster spylogsster self-assigned this Jan 19, 2023
fmarier
fmarier reviewed Jan 19, 2023
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach/screenshot looks good.

browser/ui/browser_commands.cc Outdated Show resolved Hide resolved
simonhong
simonhong approved these changes Jan 20, 2023
View reviewed changes
browser/brave_app_controller_mac.mm
@@ -36,15 +40,30 @@ - (BOOL)shouldShowCleanLinkItem {
return brave::HasSelectedURL([self getBrowser]);
}

- (void)setKeyEquivalentToItem:(NSMenuItem*)item {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this method can have bool args whether copy item or not.

browser/brave_app_controller_mac.mm Outdated Show resolved Hide resolved
browser/brave_app_controller_mac.mm Outdated Show resolved Hide resolved
@spylogsster spylogsster mentioned this pull request Jan 20, 2023
Closed
25 tasks
@spylogsster spylogsster force-pushed the brave-26761-mac-app-menu branch 3 times, most recently from 3f79c43 to 0ede2dd Compare January 20, 2023 14:54
fmarier
fmarier approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not review the actual code changes, but screenshot and approach are 👍 from me.

@spylogsster spylogsster merged commit c2c003a into master Jan 21, 2023
@spylogsster spylogsster deleted the brave-26761-mac-app-menu branch January 21, 2023 13:03
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmarier fmarier fmarier approved these changes

@simonhong simonhong simonhong approved these changes

@bsclifton bsclifton Awaiting requested review from bsclifton

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging this pull request may close these issues.

Assign Copy keyboard shortcut to "copy clean link" - Mac App Menu part
3 participants
@spylogsster @fmarier @simonhong