Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly tips are now shown in Rewards panel summary. #1721

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Monthly tips are now shown in Rewards panel summary. #1721

merged 1 commit into from
Feb 19, 2019

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Feb 19, 2019

Fixes brave/brave-browser#3177

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave clean profile with reconcile-interval=10 (or lower if faster) and enable rewards.
  2. Create a recurring monthly donation to a verified publisher.
  3. optionally visit sites to populate autocontribute table.
  4. optionally make one time tip to verified publisher.
  5. When reconcilation has occurred, make sure Monthly Tips is displayed in Rewards panel summary

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monthly Tips not displayed in Rewards Summary when accessed from BAT logo
2 participants