Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shields: ensure event target exist before blur happens #3034

Merged
merged 1 commit into from
Jul 30, 2019
Merged

shields: ensure event target exist before blur happens #3034

merged 1 commit into from
Jul 30, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#5338

Test Plan:

  1. Visit a website
  2. Open Shields
  3. Block scripts
  4. Click to see which scripts blocked
  5. Click Go back
  6. Should go back

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto requested a review from yrliou July 26, 2019 22:52
@cezaraugusto cezaraugusto self-assigned this Jul 26, 2019
yrliou
yrliou approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yrliou yrliou merged commit 45cc4ed into master Jul 30, 2019
@yrliou yrliou deleted the ca-5338 branch July 30, 2019 19:19
@cezaraugusto cezaraugusto added this to the 0.70.x - Nightly milestone Jul 30, 2019
cezaraugusto pushed a commit that referenced this pull request Jul 31, 2019
@yrliou @cezaraugusto
Merge pull request #3034 from brave/ca-5338
bd25fc7 
shields: ensure event target exist before blur happens
@cezaraugusto cezaraugusto mentioned this pull request Jul 31, 2019
Merged
@btlechowski btlechowski mentioned this pull request Aug 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

Assignees

@cezaraugusto cezaraugusto

Labels
feature/shields
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging this pull request may close these issues.

Cannot navigate back to shields from blocked script details view
2 participants
@cezaraugusto @yrliou