Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update placeholder in upload script #367

Merged
merged 1 commit into from
Aug 29, 2018
Merged

update placeholder in upload script #367

merged 1 commit into from
Aug 29, 2018

Conversation

mbacchi
Copy link
Contributor

@mbacchi mbacchi commented Aug 28, 2018

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@mbacchi mbacchi self-assigned this Aug 28, 2018
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please post an issue in brave/brave-browser and mark as fixed here.

@mbacchi
Copy link
Contributor Author

mbacchi commented Aug 29, 2018

Fixes brave/brave-browser#880

@bbondy bbondy merged commit 6762794 into master Aug 29, 2018
@bsclifton bsclifton deleted the placeholder branch September 26, 2018 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants